From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH v3 02/32] drm/exynos: Merge overlay_ops into manager_ops
Date: Fri, 01 Nov 2013 20:55:05 +0100
Message-ID: <1391373.MGijs5kWOc@flatron>
References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org>
	<1403888.Y8mcJtf5WK@flatron>
	<CAOw6vbKR190d7bLTTcOOdEEUA4RFwv4Fhyn-eNg4Wh5Ggxu-GA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
	[209.85.214.53])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3EEBDF0796
	for <dri-devel@lists.freedesktop.org>;
	Fri,  1 Nov 2013 12:55:04 -0700 (PDT)
Received: by mail-bk0-f53.google.com with SMTP id w11so1604921bkz.40
	for <dri-devel@lists.freedesktop.org>;
	Fri, 01 Nov 2013 12:55:03 -0700 (PDT)
In-Reply-To: <CAOw6vbKR190d7bLTTcOOdEEUA4RFwv4Fhyn-eNg4Wh5Ggxu-GA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>, =?ISO-8859-1?Q?St=E9phane?= Marchesin <marcheu@chromium.org>
List-Id: dri-devel@lists.freedesktop.org

Hi Sean,

On Friday 01 of November 2013 15:50:05 Sean Paul wrote:
> On Thu, Oct 31, 2013 at 7:39 PM, Tomasz Figa <tomasz.figa@gmail.com> 
wrote:
> > Hi Sean,
> > 
> > On Tuesday 29 of October 2013 12:12:48 Sean Paul wrote:
[snip]
> >> -static void fimd_wait_for_vblank(struct device *dev)
> >> -{
> >> -     struct fimd_context *ctx = get_fimd_context(dev);
> >> -
> >> -     if (ctx->suspended)
> >> -             return;
> >> -
> >> -     atomic_set(&ctx->wait_vsync_event, 1);
> >> -
> >> -     /*
> >> -      * wait for FIMD to signal VSYNC interrupt or return after
> >> -      * timeout which is set to 50ms (refresh rate of 20).
> >> -      */
> >> -     if (!wait_event_timeout(ctx->wait_vsync_queue,
> >> -                             !atomic_read(&ctx->wait_vsync_event),
> >> -                             DRM_HZ/20))
> >> -             DRM_DEBUG_KMS("vblank wait timed out.\n");
> >> -}
> > 
> > Do you need all the churn of moving all the functions above? I believe
> > it would be enough to simply move the structure. This would greatly
> > decrease the diffstat and chances of possible merge conflicts.
> 
> Hi Tomasz,
> I've done as you suggest,

Thanks.

> I'll post a new version once we settle on
> the other issues you brought up.

Okay.

I'm yet to review remaining patches from this series (I hope to review 
next 5-7 patches later today), as it is quite a lot of changes, so stay 
tuned for further comments. ;)

Best regards,
Tomasz