From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Emil Velikov <emil.l.velikov@gmail.com>,
Rob Clark <robclark@freedesktop.org>
Subject: [PATCHv2 3/4] st/xa: missing handle type
Date: Mon, 10 Feb 2014 13:34:20 -0500 [thread overview]
Message-ID: <1392057261-25942-4-git-send-email-robdclark@gmail.com> (raw)
In-Reply-To: <1392057261-25942-1-git-send-email-robdclark@gmail.com>
From: Rob Clark <robclark@freedesktop.org>
DRM_API_HANDLE_TYPE_SHARED is zero, so doesn't actually fix anything.
But we shouldn't rely on SHARED handle type being zero.
Signed-off-by: Rob Clark <robclark@freedesktop.org>
---
src/gallium/state_trackers/xa/xa_tracker.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/state_trackers/xa/xa_tracker.c b/src/gallium/state_trackers/xa/xa_tracker.c
index 6943a29..01db945 100644
--- a/src/gallium/state_trackers/xa/xa_tracker.c
+++ b/src/gallium/state_trackers/xa/xa_tracker.c
@@ -370,6 +370,7 @@ xa_surface_from_handle(struct xa_tracker *xa,
{
struct winsys_handle whandle;
memset(&whandle, 0, sizeof(whandle));
+ whandle.type = DRM_API_HANDLE_TYPE_SHARED;
whandle.handle = handle;
whandle.stride = stride;
return surface_create(xa, width, height, depth, stype, xa_format, flags, &whandle);
--
1.8.5.3
next prev parent reply other threads:[~2014-02-10 18:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 18:34 [PATCHv2 0/4] enable XA for freedreno Rob Clark
2014-02-10 18:34 ` [PATCHv2 1/4] pipe-loader: split out "client" version Rob Clark
2014-02-11 19:12 ` Emil Velikov
2014-02-10 18:34 ` [PATCHv2 2/4] st/xa: use pipe-loader to get screen Rob Clark
2014-02-11 4:36 ` Emil Velikov
2014-02-11 12:08 ` Rob Clark
2014-02-11 12:38 ` Emil Velikov
2014-02-11 13:19 ` Rob Clark
2014-02-10 18:34 ` Rob Clark [this message]
2014-02-10 18:34 ` [PATCHv2 4/4] pipe-loader: add pipe loader for freedreno/msm Rob Clark
2014-02-11 4:30 ` Emil Velikov
2014-02-11 12:09 ` Rob Clark
2014-02-11 12:30 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392057261-25942-4-git-send-email-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=robclark@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox