From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinclair Yeh Subject: [PATCH] Prevent zero sized wl_egl_window Date: Wed, 12 Feb 2014 16:21:11 -0800 Message-ID: <1392250871-3224-1-git-send-email-sinclair.yeh@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: wayland-devel-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: wayland-devel-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: wayland-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Sinclair Yeh List-Id: dri-devel@lists.freedesktop.org It is illegal to create or resize a window to zero (or negative) width and/or height. This patch prevents such a request from happening. --- src/egl/wayland/wayland-egl/wayland-egl.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/egl/wayland/wayland-egl/wayland-egl.c b/src/egl/wayland/wayland-egl/wayland-egl.c index 8bd49cf..ae78595 100644 --- a/src/egl/wayland/wayland-egl/wayland-egl.c +++ b/src/egl/wayland/wayland-egl/wayland-egl.c @@ -9,6 +9,9 @@ wl_egl_window_resize(struct wl_egl_window *egl_window, int width, int height, int dx, int dy) { + if (width <= 0 || height <= 0) + return; + egl_window->width = width; egl_window->height = height; egl_window->dx = dx; @@ -24,6 +27,9 @@ wl_egl_window_create(struct wl_surface *surface, { struct wl_egl_window *egl_window; + if (width <= 0 || height <= 0) + return NULL; + egl_window = malloc(sizeof *egl_window); if (!egl_window) return NULL; -- 1.8.1.4