Re: [PATCH] Prevent zero sized wl_egl_window

["Yeh, Sinclair" <sinclair.yeh@intel.com>]

> The below seems fine, but I wonder if we could make this one cause an
> error to be returned later where we can, rather than silently ignoring.
> I'm not sure where or how, though.

Would it make sense to change wl_egl_window_resize() so that it return a
value?  Either that, or it should be documented somewhere in the API
spec that setting width/height <=0 will be ignored.


> 
> Surely drivers have maximum size limits, too, those must be catched
> somewhere already.
> 
> >  	egl_window->width  = width;
> >  	egl_window->height = height;
> >  	egl_window->dx     = dx;
> > @@ -24,6 +27,9 @@ wl_egl_window_create(struct wl_surface *surface,
> >  {
> >  	struct wl_egl_window *egl_window;
> >  
> > +	if (width <= 0 || height <= 0)
> > +		return NULL;
> > +
> >  	egl_window = malloc(sizeof *egl_window);
> >  	if (!egl_window)
> >  		return NULL;
> 
> Thanks,
> pq
> _______________________________________________
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel