dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH 16/16] drm: spiff out FB refcnting traces
Date: Tue, 18 Mar 2014 17:22:53 -0400	[thread overview]
Message-ID: <1395177773-800-17-git-send-email-robdclark@gmail.com> (raw)
In-Reply-To: <1395177773-800-1-git-send-email-robdclark@gmail.com>

I find myself making this change locally whenever debugging FB reference
counting.  Which seems a bit silly.

Signed-off-by: Rob Clark <robdclark@gmail.com>
---
 drivers/gpu/drm/drm_crtc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 9f2db6c..77d1ff1 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -600,7 +600,7 @@ EXPORT_SYMBOL(drm_framebuffer_lookup);
  */
 void drm_framebuffer_unreference(struct drm_framebuffer *fb)
 {
-	DRM_DEBUG("FB ID: %d\n", fb->base.id);
+	DRM_DEBUG("%p: FB ID: %d (%d)\n", fb, fb->base.id, fb->refcount.refcount.counter);
 	kref_put(&fb->refcount, drm_framebuffer_free);
 }
 EXPORT_SYMBOL(drm_framebuffer_unreference);
@@ -611,7 +611,7 @@ EXPORT_SYMBOL(drm_framebuffer_unreference);
  */
 void drm_framebuffer_reference(struct drm_framebuffer *fb)
 {
-	DRM_DEBUG("FB ID: %d\n", fb->base.id);
+	DRM_DEBUG("%p: FB ID: %d (%d)\n", fb, fb->base.id, fb->refcount.refcount.counter);
 	kref_get(&fb->refcount);
 }
 EXPORT_SYMBOL(drm_framebuffer_reference);
@@ -623,7 +623,7 @@ static void drm_framebuffer_free_bug(struct kref *kref)
 
 static void __drm_framebuffer_unreference(struct drm_framebuffer *fb)
 {
-	DRM_DEBUG("FB ID: %d\n", fb->base.id);
+	DRM_DEBUG("%p: FB ID: %d (%d)\n", fb, fb->base.id, fb->refcount.refcount.counter);
 	kref_put(&fb->refcount, drm_framebuffer_free_bug);
 }
 
-- 
1.8.5.3

  parent reply	other threads:[~2014-03-18 21:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 21:22 [PATCH 00/16] Atomic/nuclear modeset/pageflip Rob Clark
2014-03-18 21:22 ` [PATCH 01/16] drm: fix typo Rob Clark
2014-03-18 21:22 ` [PATCH 02/16] drm: add atomic fxns Rob Clark
2014-03-18 21:22 ` [PATCH 03/16] drm: convert crtc to ww_mutex Rob Clark
2014-03-18 21:22 ` [PATCH 04/16] drm: add object property type Rob Clark
2014-03-18 21:22 ` [PATCH 05/16] drm: add signed-range " Rob Clark
2014-03-18 21:22 ` [PATCH 06/16] drm: helpers to find mode objects Rob Clark
2014-03-18 21:22 ` [PATCH 07/16] drm: split propvals out and blob property support Rob Clark
2014-03-18 21:22 ` [PATCH 08/16] drm: Allow drm_mode_object_find() to look up an object of any type Rob Clark
2014-03-18 21:22 ` [PATCH 09/16] drm: Refactor object property check code Rob Clark
2014-03-18 21:22 ` [PATCH 10/16] drm: allow FB's in drm_mode_object_find Rob Clark
2014-03-18 21:22 ` [PATCH 11/16] drm: convert plane to properties/state Rob Clark
2014-03-18 21:22 ` [PATCH 12/16] drm: convert crtc " Rob Clark
2014-03-18 21:22 ` [PATCH 13/16] drm: push locking down into restore_fbdev_mode Rob Clark
2014-03-18 21:22 ` [PATCH 14/16] drm: Atomic modeset ioctl Rob Clark
2014-03-18 21:22 ` [PATCH 15/16] drm/msm: add atomic support Rob Clark
2014-03-18 21:22 ` Rob Clark [this message]
2014-03-19 11:07 ` [PATCH 00/16] Atomic/nuclear modeset/pageflip Daniel Vetter
2014-03-19 12:23   ` Rob Clark
2014-03-19 13:39     ` Daniel Vetter
2014-03-20 22:34     ` Greg Hackmann
2014-03-21  0:28       ` Rob Clark
2014-03-26 21:21         ` Greg Hackmann
2014-03-26 10:08       ` Daniel Vetter
2014-03-26 21:33         ` Greg Hackmann
2014-03-26 22:33           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395177773-800-17-git-send-email-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox