From: "Michel Dänzer" <michel@daenzer.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/mm: Fix search for smallest hole satisfying constraints
Date: Thu, 20 Mar 2014 18:45:47 +0900 [thread overview]
Message-ID: <1395308747.1822.7.camel@thor.local> (raw)
In-Reply-To: <20140319103818.GP30571@phenom.ffwll.local>
On Mit, 2014-03-19 at 11:38 +0100, Daniel Vetter wrote:
> On Wed, Mar 19, 2014 at 05:42:27PM +0900, Michel Dänzer wrote:
> > On Die, 2014-03-18 at 11:01 +0100, Daniel Vetter wrote:
> > > On Tue, Mar 18, 2014 at 09:58:14AM +0900, Michel Dänzer wrote:
> > > > From: Michel Dänzer <michel.daenzer@amd.com>
> > > >
> > > > entry->size is the size of the node, not the size of the hole after it.
> > > > So the code would actually find the hole which can satisfy the
> > > > constraints and which is preceded by the smallest node, not the smallest
> > > > hole satisfying the constraints.
> > > >
> > > > Reported-by: "Huang, FrankR" <FrankR.Huang@amd.com>
> > > > Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
> > >
> > > But drm-next just gained my kerneldoc patch for drm_mm, so can you please
> > > respin your patch and update the docs too?
> >
> > What kind of update are you thinking of?
>
> you've changed the function parameters, which breaks the kerneldoc. v2 is
> ok in that regard.
Ah, I see.
> > Meanwhile, I've submitted a less invasive v2 fix.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> on that one.
Merci! :)
> > BTW, do you think the fix would interact properly with coloring?
>
> Coloring only adjusts start/end so won't affect the size of the hole. If
> you really see benefits from best_match
I've been wondering about the potential effects of this fix... I hope it
won't cause regressions.
> then I guess you could look into pessimising holes which need to be
> split, presuming radeon has a pile of alignment or otherwise
> constrained buffers.
E.g. textures with 2D tiling can require pretty large alignment, so that
might indeed be interesting.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-03-20 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 0:58 [PATCH] drm/mm: Fix search for smallest hole satisfying constraints Michel Dänzer
2014-03-18 10:01 ` Daniel Vetter
2014-03-19 8:42 ` Michel Dänzer
2014-03-19 10:38 ` Daniel Vetter
2014-03-20 9:45 ` Michel Dänzer [this message]
2014-03-19 8:37 ` [PATCH v2] " Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395308747.1822.7.camel@thor.local \
--to=michel@daenzer.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox