From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: Re: [PATCH v5 15/17] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI Date: Tue, 11 Dec 2018 22:05:43 +0530 Message-ID: <14061728-2ca3-3342-2cf3-b8588b112f5f@openedev.com> References: <20181210161729.29720-1-jagan@amarulasolutions.com> <20181210161729.29720-16-jagan@amarulasolutions.com> <20181211163222.hk647c24cjhmwrz4@flea> Reply-To: jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20181211163222.hk647c24cjhmwrz4@flea> Content-Language: en-US List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org, Jagan Teki Cc: Chen-Yu Tsai , Michael Turquette , Stephen Boyd , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Michael Trimarchi , linux-sunxi , linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org List-Id: dri-devel@lists.freedesktop.org On 11/12/18 10:02 PM, Maxime Ripard wrote: > On Mon, Dec 10, 2018 at 09:47:27PM +0530, Jagan Teki wrote: >> Minimum PLL used for MIPI is 500MHz, as per manual, but >> lowering the min rate by 300MHz can result proper working >> nkms divider with the help of desired dclock rate from >> panel driver. >> >> Signed-off-by: Jagan Teki >> Acked-by: Stephen Boyd >> --- >> drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> index 181b599dc163..b623c8150b4f 100644 >> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> @@ -183,6 +183,7 @@ static struct ccu_nkm pll_mipi_clk = { >> .n = _SUNXI_CCU_MULT(8, 4), >> .k = _SUNXI_CCU_MULT_MIN(4, 2, 2), >> .m = _SUNXI_CCU_DIV(0, 4), >> + .min_rate = 300000000, /* Actual rate is 500MHz */ > > That comment still doesn't make any sense. Is it running at 500MHz or 300? It running in 300MHz, actual rate is 500MHz. > > Also, IIRC you had a patch adding support for maximum boundaries in > your previous patch, where did it go? Since I don't have any usecase to test I droped it. the same mentioned on the previous version.