From: Ajay Kumar <ajaykumar.rs@samsung.com>
To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org
Cc: inki.dae@samsung.com, thierry.reding@gmail.com,
robdclark@gmail.com, daniel.vetter@ffwll.ch, seanpaul@google.com,
ajaynumb@gmail.com, jg1.han@samsung.com, joshi@samsung.com,
prashanth.g@samsung.com, Ajay Kumar <ajaykumar.rs@samsung.com>
Subject: [PATCH V7 05/12] drm/exynos: dp: support drm_bridge
Date: Wed, 27 Aug 2014 19:59:39 +0530 [thread overview]
Message-ID: <1409149783-12416-6-git-send-email-ajaykumar.rs@samsung.com> (raw)
In-Reply-To: <1409149783-12416-1-git-send-email-ajaykumar.rs@samsung.com>
Modify driver to support drm_bridge.
Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
drivers/gpu/drm/exynos/Kconfig | 1 +
drivers/gpu/drm/exynos/exynos_dp_core.c | 38 +++++++++++++++++++++++--------
drivers/gpu/drm/exynos/exynos_dp_core.h | 1 +
3 files changed, 30 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 4c0e071..bdef294 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -54,6 +54,7 @@ config DRM_EXYNOS_DP
depends on DRM_EXYNOS_FIMD && ARCH_EXYNOS
default DRM_EXYNOS
select DRM_PANEL
+ select DRM_BRIDGE
help
This enables support for DP device.
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 61ce6e4..a8a8b87 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -987,9 +987,17 @@ static struct drm_connector_helper_funcs exynos_dp_connector_helper_funcs = {
};
/* returns the number of bridges attached */
-static int exynos_drm_attach_lcd_bridge(struct drm_device *dev,
+static int exynos_drm_attach_lcd_bridge(struct exynos_dp_device *dp,
struct drm_encoder *encoder)
{
+ int ret;
+
+ ret = drm_bridge_attach(dp->bridge, encoder);
+ if (ret) {
+ DRM_ERROR("Failed to attach bridge to encoder\n");
+ return ret;
+ }
+
return 0;
}
@@ -1003,9 +1011,11 @@ static int exynos_dp_create_connector(struct exynos_drm_display *display,
dp->encoder = encoder;
/* Pre-empt DP connector creation if there's a bridge */
- ret = exynos_drm_attach_lcd_bridge(dp->drm_dev, encoder);
- if (ret)
- return 0;
+ if (dp->bridge) {
+ ret = exynos_drm_attach_lcd_bridge(dp, encoder);
+ if (!ret)
+ return 0;
+ }
connector->polled = DRM_CONNECTOR_POLL_HPD;
@@ -1257,7 +1267,7 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data)
if (ret)
return ret;
- if (!dp->panel) {
+ if (!dp->panel && !dp->bridge) {
ret = exynos_dp_dt_parse_panel(dp);
if (ret)
return ret;
@@ -1348,7 +1358,7 @@ static const struct component_ops exynos_dp_ops = {
static int exynos_dp_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- struct device_node *panel_node;
+ struct device_node *node;
struct exynos_dp_device *dp;
int ret;
@@ -1362,14 +1372,22 @@ static int exynos_dp_probe(struct platform_device *pdev)
if (!dp)
return -ENOMEM;
- panel_node = of_parse_phandle(dev->of_node, "panel", 0);
- if (panel_node) {
- dp->panel = of_drm_find_panel(panel_node);
- of_node_put(panel_node);
+ node = of_parse_phandle(dev->of_node, "panel", 0);
+ if (node) {
+ dp->panel = of_drm_find_panel(node);
+ of_node_put(node);
if (!dp->panel)
return -EPROBE_DEFER;
}
+ node = of_parse_phandle(dev->of_node, "bridge", 0);
+ if (node) {
+ dp->bridge = of_drm_find_bridge(node);
+ of_node_put(node);
+ if (!dp->bridge)
+ return -EPROBE_DEFER;
+ }
+
exynos_dp_display.ctx = dp;
ret = component_add(&pdev->dev, &exynos_dp_ops);
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.h b/drivers/gpu/drm/exynos/exynos_dp_core.h
index a1aee69..3b0ba93 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.h
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.h
@@ -150,6 +150,7 @@ struct exynos_dp_device {
struct drm_connector connector;
struct drm_encoder *encoder;
struct drm_panel *panel;
+ struct drm_bridge *bridge;
struct clk *clock;
unsigned int irq;
void __iomem *reg_base;
--
1.7.9.5
next prev parent reply other threads:[~2014-08-27 14:29 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 14:29 [PATCH V7 00/12] drm/exynos: few patches to enhance bridge chip support Ajay Kumar
2014-08-27 14:29 ` [PATCH V7 01/12] drm/bridge: ptn3460: Few trivial cleanups Ajay Kumar
2014-08-27 14:29 ` [PATCH V7 02/12] drm/bridge: do not pass drm_bridge_funcs to drm_bridge_init Ajay Kumar
2014-10-27 19:50 ` Sean Paul
2014-08-27 14:29 ` [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge Ajay Kumar
2014-10-27 19:01 ` Daniel Vetter
2014-10-27 19:58 ` Sean Paul
2014-10-27 22:20 ` Daniel Vetter
2014-10-27 22:26 ` Daniel Vetter
2014-10-27 23:57 ` Russell King - ARM Linux
2014-11-04 9:22 ` Philipp Zabel
2014-10-28 14:35 ` Thierry Reding
2014-10-29 7:43 ` Daniel Vetter
2014-10-29 8:38 ` Thierry Reding
2014-10-29 8:57 ` Daniel Vetter
2014-10-29 9:14 ` Thierry Reding
2014-10-30 10:01 ` Andrzej Hajda
2014-10-30 10:09 ` Russell King - ARM Linux
2014-10-31 15:54 ` Daniel Vetter
2014-10-31 15:51 ` Daniel Vetter
2014-11-03 8:01 ` Thierry Reding
2014-11-03 8:26 ` Ajay kumar
2014-10-28 14:29 ` Thierry Reding
2014-10-29 7:51 ` Daniel Vetter
2014-10-29 9:16 ` Thierry Reding
2014-10-31 15:59 ` Daniel Vetter
2014-11-03 8:06 ` Thierry Reding
2014-11-03 8:11 ` Daniel Vetter
2014-10-28 9:21 ` Ajay kumar
2014-10-28 10:01 ` Daniel Vetter
2014-10-28 12:28 ` Ajay kumar
2014-10-28 14:19 ` Daniel Vetter
2014-10-28 14:28 ` Sean Paul
2014-10-28 14:41 ` Thierry Reding
2014-10-28 14:46 ` Ajay kumar
2014-10-28 15:05 ` Thierry Reding
2014-10-29 7:58 ` Daniel Vetter
2014-10-29 9:09 ` Andrzej Hajda
2014-10-31 16:03 ` Daniel Vetter
2014-10-27 20:11 ` Sean Paul
2014-10-28 9:22 ` Ajay kumar
2014-10-28 9:26 ` Ajay kumar
2014-08-27 14:29 ` [PATCH V7 04/12] drm/bridge: ptn3460: Convert to i2c driver model Ajay Kumar
2014-08-27 14:29 ` Ajay Kumar [this message]
2014-08-27 14:29 ` [PATCH V7 06/12] drm/bridge: ptn3460: support drm_panel Ajay Kumar
2014-08-27 14:29 ` [PATCH V7 07/12] drm/bridge: ptn3460: probe connector at the end of bridge attach Ajay Kumar
2014-08-27 14:29 ` [PATCH V7 08/12] drm/bridge: ptn3460: use gpiod interface Ajay Kumar
2014-08-27 14:29 ` [PATCH V7 12/12] drm/bridge: Add i2c based driver for ps8622/ps8625 bridge Ajay Kumar
2014-09-10 13:18 ` [PATCH V7 00/12] drm/exynos: few patches to enhance bridge chip support Ajay kumar
2014-09-16 12:44 ` Javier Martinez Canillas
2014-09-16 20:11 ` Laurent Pinchart
2014-09-17 9:32 ` Ajay kumar
2014-09-20 11:27 ` Ajay kumar
2014-09-22 10:18 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409149783-12416-6-git-send-email-ajaykumar.rs@samsung.com \
--to=ajaykumar.rs@samsung.com \
--cc=ajaynumb@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=joshi@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=prashanth.g@samsung.com \
--cc=robdclark@gmail.com \
--cc=seanpaul@google.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).