From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: [PATCH 2/9] drm/omap: page_flip: return -EBUSY if flip pending
Date: Wed, 24 Sep 2014 16:11:43 +0300 [thread overview]
Message-ID: <1411564310-732-3-git-send-email-tomi.valkeinen@ti.com> (raw)
In-Reply-To: <1411564310-732-1-git-send-email-tomi.valkeinen@ti.com>
The DRM documentation says:
"If a page flip is already pending, the page_flip operation must return
-EBUSY."
Currently omapdrm returns -EINVAL instead. Fix omapdrm by returning
-EBUSY.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_crtc.c
index 2d28dc337cfb..0812b0f80167 100644
--- a/drivers/gpu/drm/omapdrm/omap_crtc.c
+++ b/drivers/gpu/drm/omapdrm/omap_crtc.c
@@ -360,7 +360,7 @@ static int omap_crtc_page_flip_locked(struct drm_crtc *crtc,
if (omap_crtc->old_fb) {
spin_unlock_irqrestore(&dev->event_lock, flags);
dev_err(dev->dev, "already a pending flip\n");
- return -EINVAL;
+ return -EBUSY;
}
omap_crtc->event = event;
--
1.9.1
next prev parent reply other threads:[~2014-09-24 13:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 13:11 [PATCH 0/9] drm/omap: misc fixes Tomi Valkeinen
2014-09-24 13:11 ` [PATCH 1/9] drm/omap: fix encoder-crtc mapping Tomi Valkeinen
2014-09-24 13:11 ` Tomi Valkeinen [this message]
2014-09-24 13:11 ` [PATCH 3/9] drm/omap: fix race issue with vsync irq and apply Tomi Valkeinen
2014-09-24 13:11 ` [PATCH 4/9] drm/omap: clear omap_obj->paddr in omap_gem_put_paddr() Tomi Valkeinen
2014-09-24 13:11 ` [PATCH 5/9] drm/omap: add pin refcounting to omap_framebuffer Tomi Valkeinen
2014-09-24 13:11 ` [PATCH 6/9] drm/omap: add a comment why locking is missing Tomi Valkeinen
2014-09-24 13:11 ` [PATCH 7/9] drm/omap: fix operation without fbdev Tomi Valkeinen
2014-09-24 13:11 ` [PATCH 8/9] drm/omap: fix error handling in omap_framebuffer_create() Tomi Valkeinen
2014-09-24 13:11 ` [PATCH 9/9] drm/omap: handle mismatching color format and buffer width Tomi Valkeinen
2014-09-24 13:48 ` [PATCH 10/10] drm/omap: fix TILER on OMAP5 Tomi Valkeinen
-- strict thread matches above, loose matches on Subject: below --
2014-09-03 11:55 [PATCH 1/9] drm/omap: fix encoder-crtc mapping Tomi Valkeinen
2014-09-03 11:55 ` [PATCH 2/9] drm/omap: page_flip: return -EBUSY if flip pending Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411564310-732-3-git-send-email-tomi.valkeinen@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).