dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>, dri-devel@lists.freedesktop.org
Subject: [PATCH v4 06/16] drm/panel: s6e8aa0: Use standard MIPI DSI function
Date: Mon,  3 Nov 2014 10:13:31 +0100	[thread overview]
Message-ID: <1415006021-29313-6-git-send-email-thierry.reding@gmail.com> (raw)
In-Reply-To: <1415006021-29313-1-git-send-email-thierry.reding@gmail.com>

From: Thierry Reding <treding@nvidia.com>

Use the newly introduced mipi_dsi_set_maximum_return_packet_size()
function to replace an open-coded version.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/panel/panel-s6e8aa0.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c b/drivers/gpu/drm/panel/panel-s6e8aa0.c
index 0f85a7c37687..c31e2953f290 100644
--- a/drivers/gpu/drm/panel/panel-s6e8aa0.c
+++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c
@@ -800,27 +800,15 @@ static void s6e8aa0_panel_init(struct s6e8aa0 *ctx)
 }
 
 static void s6e8aa0_set_maximum_return_packet_size(struct s6e8aa0 *ctx,
-						   int size)
+						   u16 size)
 {
 	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
-	const struct mipi_dsi_host_ops *ops = dsi->host->ops;
-	u8 buf[] = {size, 0};
-	struct mipi_dsi_msg msg = {
-		.channel = dsi->channel,
-		.type = MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE,
-		.tx_len = sizeof(buf),
-		.tx_buf = buf
-	};
 	int ret;
 
 	if (ctx->error < 0)
 		return;
 
-	if (!ops || !ops->transfer)
-		ret = -EIO;
-	else
-		ret = ops->transfer(dsi->host, &msg);
-
+	ret = mipi_dsi_set_maximum_return_packet_size(dsi, size);
 	if (ret < 0) {
 		dev_err(ctx->dev,
 			"error %d setting maximum return packet size to %d\n",
-- 
2.1.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2014-11-03  9:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03  9:13 [PATCH v4 01/16] drm/dsi: Add message to packet translator Thierry Reding
2014-11-03  9:13 ` [PATCH v4 02/16] drm/dsi: Add DSI transfer helper Thierry Reding
2014-11-04 11:47   ` Andrzej Hajda
2014-11-03  9:13 ` [PATCH v4 03/16] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical Thierry Reding
2014-11-03  9:13 ` [PATCH v4 04/16] drm/dsi: Constify mipi_dsi_msg Thierry Reding
2014-11-03  9:13 ` [PATCH v4 05/16] drm/dsi: Add mipi_dsi_set_maximum_return_packet_size() helper Thierry Reding
2014-11-03  9:13 ` Thierry Reding [this message]
2014-11-03  9:13 ` [PATCH v4 07/16] drm/dsi: Implement generic read and write commands Thierry Reding
2014-11-03  9:13 ` [PATCH v4 08/16] drm/dsi: Implement some standard DCS commands Thierry Reding
2014-11-03  9:13 ` [PATCH v4 09/16] drm/dsi: Add to DocBook documentation Thierry Reding
2014-11-03  9:13 ` [PATCH v4 10/16] drm/dsi: Implement DCS nop command Thierry Reding
2014-11-03  9:13 ` [PATCH v4 11/16] drm/dsi: Implement DCS soft_reset command Thierry Reding
2014-11-03  9:13 ` [PATCH v4 12/16] drm/dsi: Implement DCS get_power_mode command Thierry Reding
2014-11-03  9:13 ` [PATCH v4 13/16] drm/dsi: Implement DCS {get, set}_pixel_format commands Thierry Reding
2014-11-03 17:10   ` Sean Paul
2014-11-04 13:34     ` [PATCH v4 13/16] drm/dsi: Implement DCS {get,set}_pixel_format commands Thierry Reding
2014-11-03  9:13 ` [PATCH v4 14/16] drm/dsi: Implement DCS set_{column, page}_address commands Thierry Reding
2014-11-03  9:13 ` [PATCH v4 15/16] drm/dsi: Resolve MIPI DSI device from phandle Thierry Reding
2014-11-03  9:13 ` [PATCH v4 16/16] drm/panel: Add Sharp LQ101R1SX01 support Thierry Reding
2014-11-03 17:28   ` Sean Paul
2014-11-04 10:41   ` Andrzej Hajda
2014-11-04 13:29     ` Thierry Reding
2014-11-05 14:39       ` Andrzej Hajda
2014-11-04 11:43 ` [PATCH v4 01/16] drm/dsi: Add message to packet translator Andrzej Hajda
2014-11-04 13:58   ` Thierry Reding
2014-11-04 14:21     ` Andrzej Hajda
2014-11-04 14:39       ` Thierry Reding
2014-11-05 13:35         ` Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415006021-29313-6-git-send-email-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=a.hajda@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox