From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 7/7] drm/i915: Drop unused position fields
Date: Thu, 13 Nov 2014 10:43:26 -0800 [thread overview]
Message-ID: <1415904206-22548-8-git-send-email-matthew.d.roper@intel.com> (raw)
In-Reply-To: <1415904206-22548-1-git-send-email-matthew.d.roper@intel.com>
The userspace-requested plane coordinates are now stored in
plane->state.base (and the i915-adjusted values are stored in
plane->state), so we no longer use the coordinate fields in intel_plane
or the orig_{src,dst} fields in intel_plane_state. Drop them.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 16 ----------------
drivers/gpu/drm/i915/intel_drv.h | 6 ------
drivers/gpu/drm/i915/intel_sprite.c | 8 --------
3 files changed, 30 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 8d5a3b4..a595a58 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11526,14 +11526,6 @@ intel_commit_primary_plane(struct drm_plane *plane,
crtc->x = src->x1;
crtc->y = src->y1;
- intel_plane->crtc_x = state->orig_dst.x1;
- intel_plane->crtc_y = state->orig_dst.y1;
- intel_plane->crtc_w = drm_rect_width(&state->orig_dst);
- intel_plane->crtc_h = drm_rect_height(&state->orig_dst);
- intel_plane->src_x = state->orig_src.x1;
- intel_plane->src_y = state->orig_src.y1;
- intel_plane->src_w = drm_rect_width(&state->orig_src);
- intel_plane->src_h = drm_rect_height(&state->orig_src);
intel_plane->obj = obj;
if (intel_crtc->active) {
@@ -11748,14 +11740,6 @@ intel_commit_cursor_plane(struct drm_plane *plane,
crtc->cursor_x = state->base.crtc_x;
crtc->cursor_y = state->base.crtc_y;
- intel_plane->crtc_x = state->orig_dst.x1;
- intel_plane->crtc_y = state->orig_dst.y1;
- intel_plane->crtc_w = drm_rect_width(&state->orig_dst);
- intel_plane->crtc_h = drm_rect_height(&state->orig_dst);
- intel_plane->src_x = state->orig_src.x1;
- intel_plane->src_y = state->orig_src.y1;
- intel_plane->src_w = drm_rect_width(&state->orig_src);
- intel_plane->src_h = drm_rect_height(&state->orig_src);
intel_plane->obj = obj;
if (fb != crtc->cursor->fb) {
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 1882de1..fdebeea 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -248,8 +248,6 @@ struct intel_plane_state {
struct drm_rect src;
struct drm_rect dst;
struct drm_rect clip;
- struct drm_rect orig_src;
- struct drm_rect orig_dst;
bool visible;
};
@@ -485,10 +483,6 @@ struct intel_plane {
struct drm_i915_gem_object *obj;
bool can_scale;
int max_downscale;
- int crtc_x, crtc_y;
- unsigned int crtc_w, crtc_h;
- uint32_t src_x, src_y;
- uint32_t src_w, src_h;
unsigned int rotation;
/* Since we need to change the watermarks before/after
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index 28ccaf7..9c00b68 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -1282,14 +1282,6 @@ intel_commit_sprite_plane(struct drm_plane *plane,
primary_enabled = !drm_rect_equals(dst, clip) || colorkey_enabled(intel_plane);
WARN_ON(!primary_enabled && !state->visible && intel_crtc->active);
- intel_plane->crtc_x = state->orig_dst.x1;
- intel_plane->crtc_y = state->orig_dst.y1;
- intel_plane->crtc_w = drm_rect_width(&state->orig_dst);
- intel_plane->crtc_h = drm_rect_height(&state->orig_dst);
- intel_plane->src_x = state->orig_src.x1;
- intel_plane->src_y = state->orig_src.y1;
- intel_plane->src_w = drm_rect_width(&state->orig_src);
- intel_plane->src_h = drm_rect_height(&state->orig_src);
intel_plane->obj = obj;
if (intel_crtc->active) {
--
1.8.5.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-13 18:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 18:43 [PATCH 0/7] i915 atomic plane helper conversion Matt Roper
2014-11-13 18:43 ` [PATCH 1/7] drm/i915: Make intel_plane_state subclass drm_plane_state Matt Roper
2014-11-13 21:25 ` Bob Paauwe
2014-11-13 18:43 ` [PATCH 2/7] drm/i915: Allow intel_plane_disable() to operate on all plane types Matt Roper
2014-11-13 19:11 ` Bob Paauwe
2014-11-13 19:12 ` Matt Roper
2014-11-13 19:44 ` Bob Paauwe
2014-11-13 19:23 ` Ville Syrjälä
2014-11-13 22:15 ` Matt Roper
2014-11-13 18:43 ` [PATCH 3/7] drm/i915: Clarify sprite plane function names Matt Roper
2014-11-13 21:26 ` [Intel-gfx] " Bob Paauwe
2014-11-13 18:43 ` [PATCH 4/7] drm/i915: Make intel_crtc_has_pending_flip() non-static Matt Roper
2014-11-13 21:27 ` Bob Paauwe
2014-11-13 18:43 ` [PATCH 5/7] drm/i915: Prepare for atomic plane helpers Matt Roper
2014-11-13 19:46 ` Bob Paauwe
2014-11-13 21:31 ` Matt Roper
2014-11-13 22:51 ` [PATCH 5/8] drm/i915: Prepare for atomic plane helpers (v2) Matt Roper
2014-11-14 1:23 ` Matt Roper
2014-11-14 7:48 ` Daniel Vetter
2014-11-13 18:43 ` [PATCH 6/7] drm/i915: Switch plane handling to atomic helpers Matt Roper
2014-11-13 21:28 ` Bob Paauwe
2014-11-13 22:52 ` [PATCH 6/8] drm/i915: Switch plane handling to atomic helpers (v2) Matt Roper
2014-11-14 9:39 ` [Intel-gfx] [PATCH 6/7] drm/i915: Switch plane handling to atomic helpers Ville Syrjälä
2014-11-13 18:43 ` Matt Roper [this message]
2014-11-13 21:28 ` [PATCH 7/7] drm/i915: Drop unused position fields Bob Paauwe
2014-11-13 22:53 ` [PATCH 8/8] drm/i915: Integrate kerneldoc for atomic plane helpers Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415904206-22548-8-git-send-email-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox