From: Oded Gabbay <oded.gabbay@amd.com>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH 01/12] amdkfd: Fix sparse warnings in kfd_chardev.c
Date: Fri, 21 Nov 2014 10:43:45 +0200 [thread overview]
Message-ID: <1416559436-6595-1-git-send-email-oded.gabbay@amd.com> (raw)
In-Reply-To: <1416559111-5900-1-git-send-email-oded.gabbay@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index 64c73ba..3b3fce7 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -149,7 +149,9 @@ static int set_queue_properties_from_user(struct queue_properties *q_properties,
}
if ((args->ring_base_address) &&
- (!access_ok(VERIFY_WRITE, args->ring_base_address, sizeof(uint64_t)))) {
+ (!access_ok(VERIFY_WRITE,
+ (const void __user *) args->ring_base_address,
+ sizeof(uint64_t)))) {
pr_err("kfd: can't access ring base address\n");
return -EFAULT;
}
@@ -159,12 +161,16 @@ static int set_queue_properties_from_user(struct queue_properties *q_properties,
return -EINVAL;
}
- if (!access_ok(VERIFY_WRITE, args->read_pointer_address, sizeof(uint32_t))) {
+ if (!access_ok(VERIFY_WRITE,
+ (const void __user *) args->read_pointer_address,
+ sizeof(uint32_t))) {
pr_err("kfd: can't access read pointer\n");
return -EFAULT;
}
- if (!access_ok(VERIFY_WRITE, args->write_pointer_address, sizeof(uint32_t))) {
+ if (!access_ok(VERIFY_WRITE,
+ (const void __user *) args->write_pointer_address,
+ sizeof(uint32_t))) {
pr_err("kfd: can't access write pointer\n");
return -EFAULT;
}
@@ -325,7 +331,9 @@ static int kfd_ioctl_update_queue(struct file *filp, struct kfd_process *p,
}
if ((args.ring_base_address) &&
- (!access_ok(VERIFY_WRITE, args.ring_base_address, sizeof(uint64_t)))) {
+ (!access_ok(VERIFY_WRITE,
+ (const void __user *) args.ring_base_address,
+ sizeof(uint64_t)))) {
pr_err("kfd: can't access ring base address\n");
return -EFAULT;
}
--
2.1.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-11-21 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 8:38 [PATCH 00/12] amdkfd fixes (sparse and some more) Oded Gabbay
2014-11-21 8:43 ` Oded Gabbay [this message]
2014-11-21 8:43 ` [PATCH 02/12] amdkfd: Fix sparse warnings in kfd_topology.c Oded Gabbay
2014-11-21 8:47 ` [PATCH 03/12] amdkfd: test_kq() can be static Oded Gabbay
2014-11-21 8:47 ` [PATCH 04/12] amdkfd: pqm_get_kernel_queue() " Oded Gabbay
2014-11-21 8:47 ` [PATCH 05/12] amdkfd: Fix sparse warnings in kfd_flat_memory.c Oded Gabbay
2014-11-21 8:47 ` [PATCH 06/12] amdkfd: is_occupied() can be static Oded Gabbay
2014-11-21 8:47 ` [PATCH 07/12] amdkfd: fence_wait_timeout() " Oded Gabbay
2014-11-21 8:47 ` [PATCH 08/12] amdkfd: add __iomem attribute to doorbell_ptr Oded Gabbay
2014-11-21 8:49 ` [PATCH 09/12] amdkfd: Fix memory leak on process deregistration Oded Gabbay
2014-11-21 8:51 ` [PATCH 10/12] amdkfd: use schedule() in sync_with_hw Oded Gabbay
2014-11-21 8:51 ` [PATCH 11/12] amdkfd: Instead of using get function, use container_of Oded Gabbay
2014-11-21 8:52 ` [PATCH 12/12] amdkfd: Clear ctx cb before suspend Oded Gabbay
2014-11-21 15:06 ` [PATCH 00/12] amdkfd fixes (sparse and some more) Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416559436-6595-1-git-send-email-oded.gabbay@amd.com \
--to=oded.gabbay@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox