Re: [PATCH] drm: bridge/dw_hdmi: Fix return error path

[Philipp Zabel <p.zabel@pengutronix.de>]

Hi Thierry,

Am Mittwoch, den 28.01.2015, 09:00 +0100 schrieb Thierry Reding:
> On Tue, Jan 27, 2015 at 04:17:51PM +0100, Philipp Zabel wrote:
> > Hi Fabio,
> > 
> > Am Dienstag, den 27.01.2015, 10:54 -0200 schrieb Fabio Estevam:
> > > If devm_request_threaded_irq() fails we should jump to 'err_iahb' label that 
> > > will disable the clocks that were previously enabled.
> > > 
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > > ---
> > >  drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> > > index ed3dfe7..cd6a706 100644
> > > --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> > > +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> > > @@ -1642,7 +1642,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
> > >  					dw_hdmi_irq, IRQF_SHARED,
> > >  					dev_name(dev), hdmi);
> > >  	if (ret)
> > > -		return ret;
> > > +		goto err_iahb;
> > >  
> > >  	/*
> > >  	 * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator
> > 
> > Thanks for the fix. I have applied this to my tree since I've introduced
> > the bug in there.
> 
> I'm currently redoing the drm/{panel,bridge} pull request anyway, so I
> could apply this while at it.

Thanks, I have a few fixes for the last pull anyway:
    git://git.pengutronix.de/git/pza/linux.git tags/imx-drm-next-2015-01-28

I can remove this patch from the branch if you'll take it, let me know
what you prefer. Just in case:

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel