Re: [PATCH v2 05/10] Add RGB666_1X24_CPADHI media bus format

[Philipp Zabel <p.zabel@pengutronix.de>]

Hi Sakari,

Am Mittwoch, den 04.02.2015, 16:37 +0200 schrieb Sakari Ailus:
> Hi Philipp,
> 
> Could you add linux-media next time you send the set, please? I think 
> that's the most relevant list for the format related patches.

Will do in the next round. Let's see what Mauro thinks about your
concern regarding potential conflicts in
include/uapi/linux/media-bus-format.h when merging changes through both
drm and media.

> Philipp Zabel wrote:
> > Commit 9e74d2926a28 ("staging: imx-drm: add LVDS666 support for parallel
> > display") describes a 24-bit bus format where three 6-bit components each
> > take the lower part of 8 bits with the two high bits zero padded. Add a
> > component-wise padded media bus format RGB666_1X24_CPADHI to support this
> > connection.
> >
> > Cc: Emil Renner Berthing <kernel@esmil.dk>
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >   Documentation/DocBook/media/v4l/subdev-formats.xml | 30 ++++++++++++++++++++++
> >   include/uapi/linux/media-bus-format.h              |  3 ++-
> >   2 files changed, 32 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
> > index 8d1f624..c02af7a 100644
> > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
> > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
> > @@ -480,6 +480,36 @@ see <xref linkend="colorspaces" />.</entry>
> >   	      <entry>b<subscript>1</subscript></entry>
> >   	      <entry>b<subscript>0</subscript></entry>
> >   	    </row>
> > +	    <row id="MEDIA-BUS-FMT-RGB666-1X24_CPADHI">
> > +	      <entry>MEDIA_BUS_FMT_RGB666_1X24_CPADHI</entry>
> 
> Could you add a note on "C" in front of PADHI to the explanation in 
> media-bus-format.h?

Thanks, how about this addition:

-----8<-----
From: Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH] fixup! [media] Add RGB666_1X24_CPADHI media bus format

---
 Documentation/DocBook/media/v4l/subdev-formats.xml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
index 0b022a1..a9f62e9 100644
--- a/Documentation/DocBook/media/v4l/subdev-formats.xml
+++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
@@ -91,7 +91,9 @@ see <xref linkend="colorspaces" />.</entry>
 	<listitem><para>For formats where the total number of bits per pixel is smaller
 	than the number of bus samples per pixel times the bus width, a padding
 	value stating if the bytes are padded in their most high order bits
-	(PADHI) or low order bits (PADLO).</para></listitem>
+	(PADHI) or low order bits (PADLO). A "C" prefix is used for component-wise
+	padding in the most high order bits (CPADHI) or low order bits (CPADLO)
+	of each separate component.</para></listitem>
 	<listitem><para>For formats where the number of bus samples per pixel is larger
 	than 1, an endianness value stating if the pixel is transferred MSB first
 	(BE) or LSB first (LE).</para></listitem>
@@ -103,6 +105,10 @@ see <xref linkend="colorspaces" />.</entry>
       samples per pixel with the most significant bits (padding, red and half of
       the green value) transferred first will be named
       <constant>MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE</constant>.
+      A format where pixels are encoded as 6-bit red, green and blue values,
+      transferred as 1 24-bit sample per pixel where each component is padded to
+      8-bits with the 2-bit padding in the most significant bits will be named
+      <constant>MEDIA_BUS_FMT_RGB666_1X24_CPADHI</constant>.
       </para>
 
       <para>The following tables list existing packed RGB formats.</para>
-- 
2.1.4
----->8-----

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel