From: Jan Vesely <jan.vesely@rutgers.edu>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [libdrm][PATCH 2/2] Fix gcc -Wextra warnings
Date: Mon, 09 Feb 2015 19:02:18 -0500 [thread overview]
Message-ID: <1423526538.10898.64.camel@rutgers.edu> (raw)
In-Reply-To: <CACvgo51OoChex8WfpgRYQJx+p9DrDoVNgkcXmaVA5yOf0Mdk7w@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 911 bytes --]
On Mon, 2015-02-09 at 23:32 +0000, Emil Velikov wrote:
> On 9 February 2015 at 21:39, Jan Vesely <jan.vesely@rutgers.edu> wrote:
> > Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
> Nice one Jan. I've sent similar fixes for drmOpenDevice and
> drmGetStats a few days ago.
>
> Considering you drop the last hunk that Ian spotted both patches are
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Thanks, I sent v2 of that patch few minutes ago.
I think your 4/6 and 5/6 overlap with this one. Should I go ahead or do
you plan to push yours?
>
> The strange part is that the normal Linux build does not show even a
> single warning, despite the -Wextra and -Wsign-compare flags from
> configure.ac. Perhaps my gcc does not like libdrm for some reason :P
I think I just used CFLAGS= during configure, and it worked
jan
>
> -Emil
--
Jan Vesely <jan.vesely@rutgers.edu>
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-02-10 0:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 21:39 [libdrm][PATCH 1/2] random: Use unsigned long for seed Jan Vesely
2015-02-09 21:39 ` [libdrm][PATCH 2/2] Fix gcc -Wextra warnings Jan Vesely
2015-02-09 23:12 ` Ian Romanick
2015-02-09 23:32 ` Emil Velikov
2015-02-10 0:02 ` Jan Vesely [this message]
2015-02-10 0:27 ` Emil Velikov
2015-02-10 21:37 ` Jan Vesely
2015-02-10 22:55 ` Emil Velikov
2015-02-09 23:11 ` [libdrm][PATCH 1/2] random: Use unsigned long for seed Ian Romanick
2015-02-09 23:26 ` Jan Vesely
2015-02-09 23:28 ` [libdrm][PATCH v2 " Jan Vesely
2015-02-10 18:21 ` Ian Romanick
2015-02-10 0:10 ` [libdrm][PATCH 3/2] Fix always true comparison Jan Vesely
2015-02-25 17:11 ` Jan Vesely
2015-02-25 18:41 ` Emil Velikov
2015-03-02 20:01 ` Jan Vesely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423526538.10898.64.camel@rutgers.edu \
--to=jan.vesely@rutgers.edu \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).