From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Vesely Subject: Re: [libdrm][PATCH 2/2] Fix gcc -Wextra warnings Date: Tue, 10 Feb 2015 16:37:08 -0500 Message-ID: <1423604228.3926.44.camel@rutgers.edu> References: <1423517995-28251-1-git-send-email-jan.vesely@rutgers.edu> <1423517995-28251-2-git-send-email-jan.vesely@rutgers.edu> <1423526538.10898.64.camel@rutgers.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0683426285==" Return-path: Received: from mail-qg0-f41.google.com (mail-qg0-f41.google.com [209.85.192.41]) by gabe.freedesktop.org (Postfix) with ESMTP id BBA276E6D9 for ; Tue, 10 Feb 2015 13:37:10 -0800 (PST) Received: by mail-qg0-f41.google.com with SMTP id i50so28498242qgf.0 for ; Tue, 10 Feb 2015 13:37:10 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: ML dri-devel List-Id: dri-devel@lists.freedesktop.org --===============0683426285== Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-AzFihrRa+1+OiVEffAHB" --=-AzFihrRa+1+OiVEffAHB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-02-10 at 00:27 +0000, Emil Velikov wrote: > On 10 February 2015 at 00:02, Jan Vesely wrote: > > On Mon, 2015-02-09 at 23:32 +0000, Emil Velikov wrote: > >> On 9 February 2015 at 21:39, Jan Vesely wrote= : > >> > Signed-off-by: Jan Vesely > >> Nice one Jan. I've sent similar fixes for drmOpenDevice and > >> drmGetStats a few days ago. > >> > >> Considering you drop the last hunk that Ian spotted both patches are > >> Reviewed-by: Emil Velikov > > > > Thanks, I sent v2 of that patch few minutes ago. > > > > I think your 4/6 and 5/6 overlap with this one. Should I go ahead or do > > you plan to push yours? > > > I would go with your series - it handles more cases, plus already has > move reviews :-P > If you feel like looking through some of my series that would be apprecia= ted. I wasn't subscribed to the list so I can't reply to those emails (don't know the message-ids). I looked at the series from Jan 29th [0].=20 1/6[1], there is no tests/util directory, I guess it depends on Thierry's series? since it hasn't landed yet does it make sense to squash it there (like your 04.1/11 SQUASH: tests: misc cleanups) ? 2/6[2], also does not apply cleanly (needs Thierry's 5/11), if you want to push a version rebased on master you can add Reviewed-by: Jan Vesely to that one 4/6 and 5/6 were superseded, and I don't know enough about android to look at the other two, but 6/6 looks trivial enough Acked-by: Jan Vesely with a small nit: Why keep two assignments to LOCAL_SHARED_LIBRARIES in intel/Android.mk ? regards, jan [0]http://lists.freedesktop.org/archives/dri-devel/2015-January/076456.html [1]http://lists.freedesktop.org/archives/dri-devel/2015-January/076457.html [2]http://lists.freedesktop.org/archives/dri-devel/2015-January/076458.html >=20 > >> > >> The strange part is that the normal Linux build does not show even a > >> single warning, despite the -Wextra and -Wsign-compare flags from > >> configure.ac. Perhaps my gcc does not like libdrm for some reason :P > > > > I think I just used CFLAGS=3D during configure, and it worked > > jan > > > Yes the issue was that we're not using WARN_CFLAGS in every Makefile in l= ibdrm. > Namely the top one and most of the tests. >=20 > -Emil --=20 Jan Vesely --=-AzFihrRa+1+OiVEffAHB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJU2noEAAoJEDhUsXb6ZiH/cHUP/Aq632WjJypyZsIXr+RNzY89 D45l4oBJg9oim64TP3HCHaoXpP4hYXvPjNZbPC26DQFXGdqz0krFZVCtOnIR6Utg Sk1BplTEkEJSq2yaWoLn9PckDPMnoo7V6BwQfnXDRSvQe7oFrrvj2jqqOJMxSQCU nwSw6GzSwk+gMz8OeFpF/Sv641/ppROavJJzILt7/5Aa1ujpkDiCG4i+HafAzx4Q DwMaYSTnYhklD77e73UgBu6TlsEajatn1QQ52DNiLmyUo7aLol3dfWpN3KBo0a+p m4jolwduBT8aSpyavMoj0LBvUf1FYqQQil7Oo8d1a0sAXHyvHYUv/8DchPBKI3tf wx870Uqwx7vvrEb+E6fV+e7/CTggX3YCgOZOjppWPiS21yDyeL6zHW4yq/1Itf3a hmMIkOxZa62mI7WSxZZx2JYgaGp/HHHV0QFpA/Zcxp8NfLTIcpZghvAhXXHpAC4n ENbBWVW7vx9FGx9SSvRezuJsatRMo4VkZoUtQypz+BY+T/LLezXy8uU4g+wKdZhE pUPsW+gLPLsjn+MOexMEgF2DOTMKFcTXhnAs4IiSS31+3G8HoH0rNpFLBTRehzVV ztBM/Ta9Sb1TNMBwEE/TnC8VI4VOAG7fBn+XAhFdPwHtZ0RL3vyr7A99/j60sf5g y7oUJJUoVMhlU04MMlKg =BAC4 -----END PGP SIGNATURE----- --=-AzFihrRa+1+OiVEffAHB-- --===============0683426285== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0683426285==--