From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: [PATCH] drm/radeon: Fix regression with suspend/resume Date: Thu, 12 Feb 2015 13:30:26 -0700 Message-ID: <1423773026-5941-1-git-send-email-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: Ross Zwisler , Lauri Kasanen , =?UTF-8?q?Christian=20K=C3=B6nig?= , Dave Airlie , Alex Deucher , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This patch reverts the changes made in this commit: deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2") That patch caused a regression on my system where the bottom of the screen flickers after my laptop goes thorough a suspend and resume. This is reproducible 100% of the time. This patch applies cleanly to v3.19, and fixes the screen flicker issue on my system. Here is the hardware that I'm using (from lspci): 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Seymour [Radeon HD 6400M/7400M Series] Signed-off-by: Ross Zwisler Cc: Lauri Kasanen Cc: "Christian K=C3=B6nig" Cc: Dave Airlie Cc: Alex Deucher Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/radeon/radeon_object.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/r= adeon/radeon_object.c index 86fc564..dea1baf 100644 --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -173,17 +173,6 @@ void radeon_ttm_placement_from_domain(struct radeo= n_bo *rbo, u32 domain) else rbo->placements[i].lpfn =3D 0; } - - /* - * Use two-ended allocation depending on the buffer size to - * improve fragmentation quality. - * 512kb was measured as the most optimal number. - */ - if (rbo->tbo.mem.size > 512 * 1024) { - for (i =3D 0; i < c; i++) { - rbo->placements[i].flags |=3D TTM_PL_FLAG_TOPDOWN; - } - } } =20 int radeon_bo_create(struct radeon_device *rdev, --=20 1.9.3