From: Lucas Stach <l.stach@pengutronix.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/imx: ipuv3-crtc: Allow to divide DI clock from TVEv2
Date: Mon, 02 Mar 2015 16:40:51 +0100 [thread overview]
Message-ID: <1425310851.2816.6.camel@pengutronix.de> (raw)
In-Reply-To: <1425309897-3895-1-git-send-email-p.zabel@pengutronix.de>
Am Montag, den 02.03.2015, 16:24 +0100 schrieb Philipp Zabel:
> This patch allows the IPU to divide the 27 MHz input clock from
> the TVE by two to obtain the 13.5 MHz pixel clock needed for
> NTSC/PAL SD modes.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/gpu/drm/imx/ipuv3-crtc.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c
> index 35a3375..11a8d868 100644
> --- a/drivers/gpu/drm/imx/ipuv3-crtc.c
> +++ b/drivers/gpu/drm/imx/ipuv3-crtc.c
> @@ -161,13 +161,16 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
> __func__, encoder_types);
>
> /*
> - * If we have DAC, TVDAC or LDB, then we need the IPU DI clock
> - * to be the same as the LDB DI clock.
> + * If we have DAC or LDB, then we need the IPU DI clock to be
> + * the same as the LDB DI clock. For TVDAC, derive the IPU DI
> + * clock from 27 MHz TVE_DI clock, but allow to divide it.
> */
> if (encoder_types & (BIT(DRM_MODE_ENCODER_DAC) |
> BIT(DRM_MODE_ENCODER_TVDAC) |
I suppose the above line has to be removed for this to work properly.
> BIT(DRM_MODE_ENCODER_LVDS)))
> sig_cfg.clkflags = IPU_DI_CLKMODE_SYNC | IPU_DI_CLKMODE_EXT;
> + else if (encoder_types & BIT(DRM_MODE_ENCODER_TVDAC))
> + sig_cfg.clkflags = IPU_DI_CLKMODE_EXT;
> else
> sig_cfg.clkflags = 0;
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-02 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 15:24 [PATCH] drm/imx: ipuv3-crtc: Allow to divide DI clock from TVEv2 Philipp Zabel
2015-03-02 15:40 ` Lucas Stach [this message]
2015-03-03 7:42 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425310851.2816.6.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).