From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Vesely Subject: Re: [PATCH libdrm 7/8] Fix unused, and unused-but-set variables warnings Date: Fri, 13 Mar 2015 19:37:41 -0400 Message-ID: <1426289861.3249.10.camel@rutgers.edu> References: <1425060448-5315-1-git-send-email-jan.vesely@rutgers.edu> <1425060448-5315-8-git-send-email-jan.vesely@rutgers.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1050971555==" Return-path: Received: from mail-qc0-f177.google.com (mail-qc0-f177.google.com [209.85.216.177]) by gabe.freedesktop.org (Postfix) with ESMTP id D16456EB94 for ; Fri, 13 Mar 2015 16:37:44 -0700 (PDT) Received: by qcyi15 with SMTP id i15so1894747qcy.0 for ; Fri, 13 Mar 2015 16:37:44 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: ML dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1050971555== Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-PVLw9kSsGD96iX3QhTla" --=-PVLw9kSsGD96iX3QhTla Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-03-13 at 22:56 +0000, Emil Velikov wrote: > On 27 February 2015 at 18:07, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > tests/exynos/exynos_fimg2d_test.c | 4 +--- > > xf86drm.c | 9 ++++++--- > > 2 files changed, 7 insertions(+), 6 deletions(-) > > > ... > > @@ -333,7 +336,6 @@ static int drmOpenDevice(dev_t dev, int minor, int = type) > > drm_server_info->get_perms(&serv_group, &serv_mode); > > devmode =3D serv_mode ? serv_mode : DRM_DEV_MODE; > > devmode &=3D ~(S_IXUSR|S_IXGRP|S_IXOTH); > > - group =3D (serv_group >=3D 0) ? serv_group : DRM_DEV_GID; > > } > > > > #if !defined(UDEV) > > @@ -354,6 +356,7 @@ static int drmOpenDevice(dev_t dev, int minor, int = type) > > } > > > > if (drm_server_info) { > > + group =3D (serv_group >=3D 0) ? serv_group : DRM_DEV_GID; > I think you can leave this back where it was. It doesn't seem to bring > anything beneficial. "group" variable is now only available #if !defined(UDEV), so I can;'t really move it back without adding a pair of ifdefs, moving it here looked nicer than adding another set of #if/#endif. I wanted to move the declaration here as well, but I'm not sure how it'd play with old/broken compilers that need to be supported. jan >=20 > -Emil --=20 Jan Vesely --=-PVLw9kSsGD96iX3QhTla Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJVA3TFAAoJEDhUsXb6ZiH/VSMP/ixd8Y1CUS2xibddxbvg/9Eh I/AR10/ePTArpfDvT5uZvqW01YIMUt72HKh+mvViTwQTuSlupZDK4WpyagMZuVTf +qIADxv95cTMR9Oinyf0WeaCVHiFjsJyUY29ZxIXPsCshScBiiVJEPVky79LJBSD d8z+YJ3auzEk3znzGuaL2TrgdCPJY/azlA2fhhoRU2JVH/eovVcJ77AtoPSGdQ1y JX/4GfDHMEpKaDH9JvBvGrQ9d3EUBJxW0e3/UBMrUsjt90cT46xP1unqg5tk8ExB TnvfKvfyX1jHL+02CU9lm7XvzCYz4x42aZhM+FDwWDJC1VhjD9IH1EBj5/L4n2zO Qdx/gI1jtzRpDtS8AVxluhBWD6fWOcQNwVoWYqupcNS65J9JmSRMyGQmh3DCL2Yv Hs7HsWD90uEAHJSCSfF+9KHsQs/VYGfyn2ycCcdNSmBg4OIoISM+TY00iBmcbgzo keK10pXbGAeCVlct5ImZNOSWvSPKKj1Jaz/g4rX5T4DlTpTfp5IEkdD0wrCFBfMh NEdV4bbvvJYgar9OcfCbJqpr4kOCgX2Q9E55LvSyhPPZXhO2iUBGNA7UGnQsC6Et VjAI4G1WRkSVYMXRsVdmPCgKovEEYtC5EbJ6xY0/IfNhWJjtbk+1kdHWclX5THdZ fCx2q/nr7zvPo1tjMLlO =ItbI -----END PGP SIGNATURE----- --=-PVLw9kSsGD96iX3QhTla-- --===============1050971555== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1050971555==--