Re: [PATCH libdrm 4/8] xf86drmSL: Fix neighbour printing

From: Jan Vesely <jan.vesely@rutgers.edu>
To: "Kristian Høgsberg" <krh@bitplanet.net>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm 4/8] xf86drmSL: Fix neighbour printing
Date: Sun, 15 Mar 2015 14:31:29 -0400	[thread overview]
Message-ID: <1426444289.12145.2.camel@rutgers.edu> (raw)
In-Reply-To: <1425060448-5315-5-git-send-email-jan.vesely@rutgers.edu>

[-- Attachment #1.1: Type: text/plain, Size: 1082 bytes --]

Hi Kristian,

this patch partially reverts e4a519635:
Tidy up compile warnings by cleaning up types.

it looks to me that the xf86drmSL.c bits slipped in by accident.

thanks,
Jan

On Fri, 2015-02-27 at 13:07 -0500, Jan Vesely wrote:
> Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
> ---
>  xf86drmSL.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/xf86drmSL.c b/xf86drmSL.c
> index acddb54..2160bb8 100644
> --- a/xf86drmSL.c
> +++ b/xf86drmSL.c
> @@ -266,11 +266,14 @@ int drmSLLookupNeighbors(void *l, unsigned long key,
>      SkipListPtr   list = (SkipListPtr)l;
>      SLEntryPtr    update[SL_MAX_LEVEL + 1];
>      int           retcode = 0;
> +    SLEntryPtr    entry;
> +
> +    entry = SLLocate(list, key, update);
>  
>      *prev_key   = *next_key   = key;
>      *prev_value = *next_value = NULL;
> -	
> -    if (update[0]) {
> +
> +    if (entry && update[0]) {
>  	*prev_key   = update[0]->key;
>  	*prev_value = update[0]->value;
>  	++retcode;

-- 
Jan Vesely <jan.vesely@rutgers.edu>

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel