From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v3 28/32] drm/exynos: Implement drm_connector in hdmi directly Date: Fri, 29 Nov 2013 16:58:46 +0100 Message-ID: <1431502.jK5oHXV9M7@amdc1227> References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org> <1383063198-10526-29-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by gabe.freedesktop.org (Postfix) with ESMTP id C282AFB996 for ; Fri, 29 Nov 2013 07:58:53 -0800 (PST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MX1002LJ8E3J270@mailout3.w1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 29 Nov 2013 15:58:51 +0000 (GMT) In-reply-to: <1383063198-10526-29-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Sean Paul Cc: dri-devel@lists.freedesktop.org, marcheu@chromium.org List-Id: dri-devel@lists.freedesktop.org Hi Sean, On Tuesday 29 of October 2013 12:13:14 Sean Paul wrote: > This patch implements drm_connector in the hdmi driver directly, instead > of using exynos_drm_connector. > > Signed-off-by: Sean Paul > --- > > Changes in v3: > - Added to the patchset > > drivers/gpu/drm/exynos/exynos_hdmi.c | 126 +++++++++++++++++++++++------------ > 1 file changed, 85 insertions(+), 41 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index c6561fe..b063610 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -43,9 +43,8 @@ > #include > #include > > -#define MAX_WIDTH 1920 > -#define MAX_HEIGHT 1080 Hmm, you are removing these values, but they don't seem to be redefined in any way anywhere below. Are you removing some of the video mode checks? > #define get_hdmi_display(dev) platform_get_drvdata(to_platform_device(dev)) > +#define ctx_from_connector(c) container_of(c, struct hdmi_context, connector) > > /* AVI header and aspect ratio */ > #define HDMI_AVI_VERSION 0x02 [snip] > @@ -811,11 +816,60 @@ static int hdmi_check_mode(struct exynos_drm_display *display, > > ret = mixer_check_mode(mode); > if (ret) > - return ret; > + return MODE_BAD; Is there a need to define custom return values, instead of returning 0 or a standard error code depending on whether the mode is correct? Best regards, Tomasz