From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Ojha <mojha@codeaurora.org>
Subject: Re: [PATCH 1/3] drm/virtio: add missing drm_atomic_helper_shutdown()
 call.
Date: Mon, 1 Apr 2019 20:38:23 +0530
Message-ID: <1431a9d8-7a60-079d-57ba-33eea6d30ce2@codeaurora.org>
References: <20190401140306.28063-1-kraxel@redhat.com>
 <20190401140306.28063-2-kraxel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20190401140306.28063-2-kraxel@redhat.com>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
To: Gerd Hoffmann <kraxel@redhat.com>, dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, "open list:VIRTIO GPU DRIVER" <virtualization@lists.linux-foundation.org>, open list <linux-kernel@vger.kernel.org>
List-Id: dri-devel@lists.freedesktop.org

Please atleast mention here why it is required?

-Mukesh

On 4/1/2019 7:33 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   drivers/gpu/drm/virtio/virtgpu_display.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
> index 653ec7d0bf4d..86843a4d6102 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_display.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
> @@ -385,5 +385,6 @@ void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev)
>   
>   	for (i = 0 ; i < vgdev->num_scanouts; ++i)
>   		kfree(vgdev->outputs[i].edid);
> +	drm_atomic_helper_shutdown(vgdev->ddev);
>   	drm_mode_config_cleanup(vgdev->ddev);
>   }