From: Philipp Zabel <p.zabel@pengutronix.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 7/7] drm/imx: ipuv3-plane: add support for separate alpha planes
Date: Wed, 20 May 2015 12:51:41 +0200 [thread overview]
Message-ID: <1432119101.4466.47.camel@pengutronix.de> (raw)
In-Reply-To: <20150519165808.GR15256@phenom.ffwll.local>
Am Dienstag, den 19.05.2015, 18:58 +0200 schrieb Daniel Vetter:
[...]
> > @@ -86,13 +93,36 @@ int ipu_plane_set_base(struct ipu_plane *ipu_plane, struct drm_framebuffer *fb,
> > eba = cma_obj->paddr + fb->offsets[0] +
> > fb->pitches[0] * y + (fb->bits_per_pixel >> 3) * x;
> >
> > + switch (fb->pixel_format) {
> > + case DRM_FORMAT_RGB565_A8:
> > + case DRM_FORMAT_BGR565_A8:
> > + case DRM_FORMAT_RGB888_A8:
> > + case DRM_FORMAT_BGR888_A8:
> > + case DRM_FORMAT_RGBX8888_A8:
> > + case DRM_FORMAT_BGRX8888_A8:
> > + alpha_eba = cma_obj->paddr + fb->offsets[1] +
> > + fb->pitches[1] * y + x;
>
> You need to look at the 2nd cma_obj here, i.e. drm_fb_cma_get_gem_obj(fb, 1);
>
> Yes, userspace is allowed to hand in non-matching. And given that you
> you just reuse the cma helpers and don't reject framebuffers with
> non-matching cma objects your current planar yuv support is also already
> broken. Would be good if you could also patch modetest a bit to exercise
> this ...
> -Daniel
Ow, right. I'll have a look at this.
thanks
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-05-20 10:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 16:05 [PATCH 0/7] imx-drm: additional alpha transparency formats Philipp Zabel
2015-05-19 16:05 ` [PATCH 1/7] gpu: ipu-v3: Add support for 15-bit RGB with 1-bit alpha formats Philipp Zabel
2015-05-19 16:05 ` [PATCH 2/7] drm/imx: " Philipp Zabel
2015-05-19 16:05 ` [PATCH 3/7] gpu: ipu-v3: add support for RGBX8888 and RGBA8888 pixel formats Philipp Zabel
2015-05-19 16:05 ` [PATCH 4/7] gpu: ipu-v3: add support for separate alpha channels Philipp Zabel
2015-05-19 16:05 ` [PATCH 5/7] drm/imx: ipuv3-plane: enable support for RGBX8888 and RGBA8888 pixel formats Philipp Zabel
2015-05-19 16:06 ` [PATCH 6/7] drm: add RGB formats with separate alpha plane Philipp Zabel
2015-05-19 16:52 ` Daniel Vetter
2015-05-20 10:50 ` Philipp Zabel
2015-05-20 12:58 ` Daniel Vetter
2015-05-20 14:07 ` Ville Syrjälä
2015-05-20 14:54 ` Philipp Zabel
2015-05-20 15:09 ` Daniel Vetter
2015-05-19 16:06 ` [PATCH 7/7] drm/imx: ipuv3-plane: add support for separate alpha planes Philipp Zabel
2015-05-19 16:58 ` Daniel Vetter
2015-05-20 10:51 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432119101.4466.47.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox