From: Frediano Ziglio <fziglio@redhat.com>
To: fziglio@redhat.com, spice-devel@lists.freedesktop.org,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
airlied@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 00/11 v2] Miscellaneous stability patches
Date: Wed, 3 Jun 2015 12:09:08 +0100 [thread overview]
Message-ID: <1433329759-10082-1-git-send-email-fziglio@redhat.com> (raw)
This set of patches mainly contains fix for some memory issues
using quite aggressively surfaces and other minor problems like
images going black after a while.
There are no code change from v1, changes:
- fix path prefix
- rebased on drm-next branch;
- add "drm/qxl" prefix on subject;
- add reviewed by.
About which patches should be applied surely (attempting to put a priority)
- "Move main reference counter to GEM object instead of TTM ones" this can
causes memory corruption even not wanting to;
- "Avoid double free on error" this can be cause leaks in kernel if user space
wants, mitigated by the fact that usually DRM inodes are owned by root;
- "Handle all errors in qxl_surface_evict" could cause corruption too, not
really probable but taking into account that Xorg implementation use a lot
signals is not so impossible;
- "Handle correctly failures in qxl_alloc_relase_reserved", "Do not leak memory
if qxl_release_list_add fails" just cause leaks on situation where memory is
already REALLY low, can be omitted;
- "Fix print statement not using uninitialized variable", "Remove format string
errors" should just print garbage and debugging is disabled by default, not
necessary.
Frediano Ziglio (11):
drm/qxl: Do not cause spice-server to clean our objects
drm/qxl: Do not leak memory if qxl_release_list_add fails
drm/qxl: Fix print statement not using uninitialized variable
drm/qxl: Avoid double free on error
drm/qxl: Handle all errors in qxl_surface_evict
drm/qxl: Fix return for qxl_release_alloc
drm/qxl: Handle correctly failures in qxl_alloc_relase_reserved
drm/qxl: Remove format string errors
drm/qxl: Move main reference counter to GEM object instead of TTM ones
drm/qxl: Simplify cleaning qxl processing command
drm/qxl: Propagate correctly errors from qxlhw_handle_to_bo
drivers/gpu/drm/qxl/qxl_cmd.c | 11 +++++-----
drivers/gpu/drm/qxl/qxl_display.c | 2 +-
drivers/gpu/drm/qxl/qxl_drv.h | 2 +-
drivers/gpu/drm/qxl/qxl_gem.c | 10 +++++++--
drivers/gpu/drm/qxl/qxl_ioctl.c | 46 +++++++++++++++------------------------
drivers/gpu/drm/qxl/qxl_object.c | 11 ++++------
drivers/gpu/drm/qxl/qxl_release.c | 13 +++++++----
7 files changed, 46 insertions(+), 49 deletions(-)
--
2.1.0
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
next reply other threads:[~2015-06-03 11:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 11:09 Frediano Ziglio [this message]
2015-06-03 11:09 ` [PATCH 01/11] drm/qxl: Do not cause spice-server to clean our objects Frediano Ziglio
2015-06-03 11:09 ` [PATCH 02/11] drm/qxl: Do not leak memory if qxl_release_list_add fails Frediano Ziglio
2015-06-03 11:09 ` [PATCH 03/11] drm/qxl: Fix print statement not using uninitialized variable Frediano Ziglio
2015-06-03 11:09 ` [PATCH 04/11] drm/qxl: Avoid double free on error Frediano Ziglio
2015-06-03 11:09 ` [PATCH 05/11] drm/qxl: Handle all errors in qxl_surface_evict Frediano Ziglio
2015-06-03 11:09 ` [PATCH 06/11] drm/qxl: Fix return for qxl_release_alloc Frediano Ziglio
2015-06-03 11:09 ` [PATCH 07/11] drm/qxl: Handle correctly failures in qxl_alloc_relase_reserved Frediano Ziglio
2015-06-03 11:09 ` [PATCH 08/11] drm/qxl: Remove format string errors Frediano Ziglio
2015-06-03 11:09 ` [PATCH 09/11] drm/qxl: Move main reference counter to GEM object instead of TTM ones Frediano Ziglio
2015-06-03 11:09 ` [PATCH 10/11] drm/qxl: Simplify cleaning qxl processing command Frediano Ziglio
2015-06-03 11:09 ` [PATCH 11/11] drm/qxl: Propagate correctly errors from qxlhw_handle_to_bo Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433329759-10082-1-git-send-email-fziglio@redhat.com \
--to=fziglio@redhat.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox