dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Oded Gabbay <oded.gabbay@gmail.com>
To: dri-devel@lists.freedesktop.org, alexdeucher@gmail.com
Subject: [PATCH 10/13] drm/amdkfd: fix runlist length calculation
Date: Fri, 12 Jun 2015 22:31:18 +0300	[thread overview]
Message-ID: <1434137481-13315-11-git-send-email-oded.gabbay@gmail.com> (raw)
In-Reply-To: <1434137481-13315-1-git-send-email-oded.gabbay@gmail.com>

From: Ben Goz <ben.goz@amd.com>

The MAP_QUEUES packet length for Carrizo is different than for Kaveri.
Therefore, we now need to calculate the runlist length with regard to the
underlying H/W.

Signed-off-by: Ben Goz <ben.goz@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c
index 99b6d28..e3230cc 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c
@@ -27,6 +27,7 @@
 #include "kfd_kernel_queue.h"
 #include "kfd_priv.h"
 #include "kfd_pm4_headers.h"
+#include "kfd_pm4_headers_vi.h"
 #include "kfd_pm4_opcodes.h"
 
 static inline void inc_wptr(unsigned int *wptr, unsigned int increment_bytes,
@@ -55,6 +56,7 @@ static void pm_calc_rlib_size(struct packet_manager *pm,
 				bool *over_subscription)
 {
 	unsigned int process_count, queue_count;
+	unsigned int map_queue_size;
 
 	BUG_ON(!pm || !rlib_size || !over_subscription);
 
@@ -69,9 +71,13 @@ static void pm_calc_rlib_size(struct packet_manager *pm,
 		pr_debug("kfd: over subscribed runlist\n");
 	}
 
+	map_queue_size =
+		(pm->dqm->dev->device_info->asic_family == CHIP_CARRIZO) ?
+		sizeof(struct pm4_mes_map_queues) :
+		sizeof(struct pm4_map_queues);
 	/* calculate run list ib allocation size */
 	*rlib_size = process_count * sizeof(struct pm4_map_process) +
-		     queue_count * sizeof(struct pm4_map_queues);
+		     queue_count * map_queue_size;
 
 	/*
 	 * Increase the allocation size in case we need a chained run list
-- 
2.4.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-06-12 19:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12 19:31 [PATCH 00/13] Add Carrizo support for amdkfd Oded Gabbay
2015-06-12 19:31 ` [PATCH 01/13] drm/radeon: Modify kgd_engine_type enum to match CZ Oded Gabbay
2015-06-12 19:31 ` [PATCH 02/13] drm/amdgpu: Add H/W agnostic amdgpu <--> amdkfd interface Oded Gabbay
2015-06-12 19:31 ` [PATCH 03/13] drm/amdgpu: add amdgpu <--> amdkfd gfx7 interface Oded Gabbay
2015-06-12 19:31 ` [PATCH 04/13] drm/amdgpu: Add amdgpu <--> amdkfd gfx8 interface Oded Gabbay
2015-06-12 19:31 ` [PATCH 05/13] drm/amdkfd: Add dependency of DRM_AMDGPU to Kconfig Oded Gabbay
2015-06-12 19:31 ` [PATCH 06/13] drm/amdkfd: add supported CZ devices PCI IDs to amdkfd Oded Gabbay
2015-06-12 19:31 ` [PATCH 07/13] drm/amdkfd: add CP HWS packet headers for VI Oded Gabbay
2015-06-12 19:31 ` [PATCH 08/13] drm/amdkfd: add support for VI in MQD manager Oded Gabbay
2015-06-12 19:31 ` [PATCH 09/13] drm/amdkfd: Add support for VI in DQM Oded Gabbay
2015-06-12 19:31 ` Oded Gabbay [this message]
2015-06-12 19:31 ` [PATCH 11/13] drm/amdkfd: Implement create_map_queues() for Carrizo Oded Gabbay
2015-06-12 19:31 ` [PATCH 12/13] drm/amdkfd: Use generic defines in new amd headers Oded Gabbay
2015-06-12 19:31 ` [PATCH 13/13] drm/amdkfd: Set correct doorbell packet type for Carrizo Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434137481-13315-11-git-send-email-oded.gabbay@gmail.com \
    --to=oded.gabbay@gmail.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox