From: Grigori Goronzy <greg@chown.ath.cx>
To: dri-devel@lists.freedesktop.org
Cc: stable@vger.kernel.org
Subject: [PATCH 2/3] drm/radeon: fix HDP flushing
Date: Thu, 2 Jul 2015 11:41:11 +0200 [thread overview]
Message-ID: <1435830072-21835-2-git-send-email-greg@chown.ath.cx> (raw)
In-Reply-To: <1435830072-21835-1-git-send-email-greg@chown.ath.cx>
This was regressed by commit 39e7f6f8, although I don't know of any
actual issues caused by it.
The storage domain is read without TTM locking now, but the lock
never helped to prevent any actual races.
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/radeon/radeon_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c
index 7199e19..013ec71 100644
--- a/drivers/gpu/drm/radeon/radeon_gem.c
+++ b/drivers/gpu/drm/radeon/radeon_gem.c
@@ -476,6 +476,7 @@ int radeon_gem_wait_idle_ioctl(struct drm_device *dev, void *data,
r = ret;
/* Flush HDP cache via MMIO if necessary */
+ cur_placement = ACCESS_ONCE(robj->tbo.mem.mem_type);
if (rdev->asic->mmio_hdp_flush &&
radeon_mem_type_to_domain(cur_placement) == RADEON_GEM_DOMAIN_VRAM)
robj->rdev->asic->mmio_hdp_flush(rdev);
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-02 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 9:41 [PATCH 1/3] drm/radeon: use RCU query for GEM_BUSY syscall Grigori Goronzy
2015-07-02 9:41 ` Grigori Goronzy [this message]
2015-07-02 13:08 ` [PATCH 2/3] drm/radeon: fix HDP flushing Greg KH
2015-07-02 9:41 ` [PATCH 3/3] drm/radeon: default to 2048 MB GART size on SI+ Grigori Goronzy
2015-07-02 14:28 ` [PATCH 1/3] drm/radeon: use RCU query for GEM_BUSY syscall Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435830072-21835-2-git-send-email-greg@chown.ath.cx \
--to=greg@chown.ath.cx \
--cc=dri-devel@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox