From: Rob Herring <robh@kernel.org>
To: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 0/2] drm: CMA fbdev stride adjustment
Date: Wed, 12 Aug 2015 15:52:12 -0500 [thread overview]
Message-ID: <1439412734-8651-1-git-send-email-robh@kernel.org> (raw)
I'm working on a DRM driver for PXA1928. Other than a stride alignment
requirement of 16 bytes, I have no other reason not to use fbdev_cma.
While I can adjust the stride for drm_gem_cma_dumb_create, I cannot do
the same for drm_fbdev_cma_create without duplicating a bunch of code.
This series allows fbdev_cma users to override the fb_probe function, so
the stride can be adjusted.
It appears to me that rcar-du has a bug that it doesn't handle alignment
requirements for this case as well. Probably just getting lucky with
tested resolutions/bpp.
Also, AFAICT the Rockchip driver has no real reason to use a custom GEM
allocator instead of the CMA one. It sets the DMA_ATTR_NO_KERNEL_MAPPING
DMA attr, but that could easily be supported by the CMA allocator.
Rob
Rob Herring (2):
drm/cma: allow custom fb helper functions
drm/cma: allow adjusting the pitch for CMA fbdev
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
drivers/gpu/drm/drm_fb_cma_helper.c | 13 ++++++++++---
drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 3 ++-
drivers/gpu/drm/sti/sti_drm_drv.c | 2 +-
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
include/drm/drm_fb_cma_helper.h | 7 +++++++
include/drm/drm_fb_helper.h | 1 +
8 files changed, 24 insertions(+), 8 deletions(-)
--
2.1.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2015-08-12 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 20:52 Rob Herring [this message]
2015-08-12 20:52 ` [PATCH 1/2] drm/cma: allow custom fb helper functions Rob Herring
2015-08-12 20:52 ` [PATCH 2/2] drm/cma: allow adjusting the pitch for CMA fbdev Rob Herring
2015-08-13 6:58 ` [PATCH 0/2] drm: CMA fbdev stride adjustment Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439412734-8651-1-git-send-email-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox