dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Anderson <dianders@chromium.org>
To: airlied@linux.ie
Cc: fabio.estevam@freescale.com, ykk@rock-chips.com,
	Douglas Anderson <dianders@chromium.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	andy.yan@rock-chips.com, rmk+kernel@arm.linux.org.uk,
	treding@nvidia.com
Subject: [PATCH] CHROMIUM: drm: bridge/dw_hdmi: Eliminate unused cable_plugin
Date: Wed, 16 Sep 2015 13:41:38 -0700	[thread overview]
Message-ID: <1442436098-26608-1-git-send-email-dianders@chromium.org> (raw)

There's a member in 'struct dw_hdmi' called cable_plugin.  It's never
set to anything anywhere so thus is always false.  There's a bit of code
checking it, but since it's always false this must be dead code.
Eliminate it.

Note: if someone wants to figure out the intention of the original code
and implement whatever feature / fix was needed then we can drop this
patch.  The 'cable_plugin' member has been unused since the code was
first added in (9aaf880 imx-drm: Add mx6 hdmi transmitter support).

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
 drivers/gpu/drm/bridge/dw_hdmi.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index 0083d4e..ba90885 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -115,7 +115,6 @@ struct dw_hdmi {
 	int vic;
 
 	u8 edid[HDMI_EDID_LEN];
-	bool cable_plugin;
 
 	bool phy_enabled;
 	struct drm_display_mode previous_mode;
@@ -1203,12 +1202,6 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
 		hdmi_writeb(hdmi, val, HDMI_FC_INVIDCONF);
 }
 
-static void hdmi_enable_overflow_interrupts(struct dw_hdmi *hdmi)
-{
-	hdmi_writeb(hdmi, 0, HDMI_FC_MASK2);
-	hdmi_writeb(hdmi, 0, HDMI_IH_MUTE_FC_STAT2);
-}
-
 static void hdmi_disable_overflow_interrupts(struct dw_hdmi *hdmi)
 {
 	hdmi_writeb(hdmi, HDMI_IH_MUTE_FC_STAT2_OVERFLOW_MASK,
@@ -1285,8 +1278,6 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
 	hdmi_tx_hdcp_config(hdmi);
 
 	dw_hdmi_clear_overflow(hdmi);
-	if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
-		hdmi_enable_overflow_interrupts(hdmi);
 
 	return 0;
 }
-- 
2.6.0.rc0.131.gf624c3d

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2015-09-16 20:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 20:41 Douglas Anderson [this message]
2015-09-21  9:51 ` [PATCH] CHROMIUM: drm: bridge/dw_hdmi: Eliminate unused cable_plugin Thierry Reding
2015-09-21 14:15   ` Russell King - ARM Linux
2015-09-25  8:29     ` Philipp Zabel
2015-09-29 11:07       ` Thierry Reding
2015-09-29 15:40         ` Russell King - ARM Linux
2015-09-26 20:32     ` Fabio Estevam
2015-10-05 19:17       ` Russell King - ARM Linux
2015-10-05 19:29         ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442436098-26608-1-git-send-email-dianders@chromium.org \
    --to=dianders@chromium.org \
    --cc=airlied@linux.ie \
    --cc=andy.yan@rock-chips.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=treding@nvidia.com \
    --cc=ykk@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox