From: Philipp Zabel <p.zabel@pengutronix.de>
To: Liu Ying <Ying.Liu@freescale.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/imx: switch to universal planes
Date: Fri, 06 Nov 2015 16:25:13 +0100 [thread overview]
Message-ID: <1446823513.4569.6.camel@pengutronix.de> (raw)
In-Reply-To: <20151106135806.GA16332@shlinux2>
Am Freitag, den 06.11.2015, 21:58 +0800 schrieb Liu Ying:
> Hi Phillip,
>
> On Fri, Nov 06, 2015 at 11:12:20AM +0100, Philipp Zabel wrote:
> > Use drm_universal_plane_init to create the planes, create the primary
> > plane first and use drm_crtc_init_with_planes to associate it with
> > the crtc.
>
> It's better to mention in the commit message that this patch removes the safe
> plane which is created by create_primary_plane(). Or, at least, it fixes the
> NULL pointer dereference issue triggered by the drm modetest I mentioned in my
> patch[1].
>
> Otherwise, Acked-by: Liu Ying <Ying.Liu@freescale.com>
>
> [1] https://lkml.org/lkml/2015/11/4/107
Thank you, I'll apply it referencing this thread.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-11-06 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 10:12 [PATCH] drm/imx: switch to universal planes Philipp Zabel
2015-11-06 13:58 ` Liu Ying
2015-11-06 15:25 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446823513.4569.6.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Ying.Liu@freescale.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox