From: Harry Wentland <harry.wentland@amd.com>
To: dri-devel@lists.freedesktop.org
Cc: Mykola Lysenko <Mykola.Lysenko@amd.com>
Subject: [PATCH 1/2] drm/dp/mst: reply with ACK for UP reqs
Date: Mon, 7 Dec 2015 13:55:51 -0500 [thread overview]
Message-ID: <1449514552-10236-2-git-send-email-harry.wentland@amd.com> (raw)
In-Reply-To: <1449514552-10236-1-git-send-email-harry.wentland@amd.com>
From: Mykola Lysenko <Mykola.Lysenko@amd.com>
Currently we reply with NACK to UP requests which might
confuse receivers. We haven't seen any actual issues with
this but should still respond to UP requests correctly.
Signed-off-by: Mykola Lysenko <Mykola.Lysenko@amd.com>
---
drivers/gpu/drm/drm_dp_mst_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 809959d56d78..64a0a3729643 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -1823,7 +1823,7 @@ static int drm_dp_encode_up_ack_reply(struct drm_dp_sideband_msg_tx *msg, u8 req
{
struct drm_dp_sideband_msg_reply_body reply;
- reply.reply_type = 1;
+ reply.reply_type = 0;
reply.req_type = req_type;
drm_dp_encode_sideband_reply(&reply, msg);
return 0;
--
2.1.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-07 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 18:55 [PATCH 0/2] Two small patches for MST Harry Wentland
2015-12-07 18:55 ` Harry Wentland [this message]
2015-12-07 18:55 ` [PATCH 2/2] drm/dp/mst: save vcpi with payloads Harry Wentland
2015-12-14 15:26 ` [PATCH 0/2] Two small patches for MST Alex Deucher
2015-12-14 17:14 ` Wentland, Harry
2015-12-14 17:32 ` Daniel Vetter
2015-12-15 14:05 ` Wentland, Harry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449514552-10236-2-git-send-email-harry.wentland@amd.com \
--to=harry.wentland@amd.com \
--cc=Mykola.Lysenko@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox