dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland@amd.com>
To: dri-devel@lists.freedesktop.org
Cc: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
Subject: [PATCH 5/5] drm/dp/mst: Reverse order of MST enable and clearing VC payload table.
Date: Fri, 22 Jan 2016 17:07:29 -0500	[thread overview]
Message-ID: <1453500449-9224-6-git-send-email-harry.wentland@amd.com> (raw)
In-Reply-To: <1453500449-9224-1-git-send-email-harry.wentland@amd.com>

From: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>

On DELL U3014 if you clear the table before enabling MST it sometimes
hangs the receiver.

Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 01a7d0198e15..fc589265068b 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -1998,6 +1998,12 @@ int drm_dp_mst_topology_mgr_set_mst(struct drm_dp_mst_topology_mgr *mgr, bool ms
 		mgr->mst_primary = mstb;
 		kref_get(&mgr->mst_primary->kref);
 
+		ret = drm_dp_dpcd_writeb(mgr->aux, DP_MSTM_CTRL,
+							 DP_MST_EN | DP_UP_REQ_EN | DP_UPSTREAM_IS_SRC);
+		if (ret < 0) {
+			goto out_unlock;
+		}
+
 		{
 			struct drm_dp_payload reset_pay;
 			reset_pay.start_slot = 0;
@@ -2005,12 +2011,6 @@ int drm_dp_mst_topology_mgr_set_mst(struct drm_dp_mst_topology_mgr *mgr, bool ms
 			drm_dp_dpcd_write_payload(mgr, 0, &reset_pay);
 		}
 
-		ret = drm_dp_dpcd_writeb(mgr->aux, DP_MSTM_CTRL,
-					 DP_MST_EN | DP_UP_REQ_EN | DP_UPSTREAM_IS_SRC);
-		if (ret < 0) {
-			goto out_unlock;
-		}
-
 		queue_work(system_long_wq, &mgr->work);
 
 		ret = 0;
-- 
2.1.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-01-22 22:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22 22:07 [PATCH 0/5] Fixes for MST (daisy-chain and 4k tiles) Harry Wentland
2016-01-22 22:07 ` [PATCH 1/5] drm: Add drm_fixp_from_fraction and drm_fixp2int_ceil Harry Wentland
2016-01-22 22:07 ` [PATCH 2/5] drm/dp/mst: Calculate MST PBN with 31.32 fixed point Harry Wentland
2016-01-22 22:07 ` [PATCH 3/5] drm/dp/mst: change MST detection scheme Harry Wentland
2016-02-17  5:45   ` Dave Airlie
2016-02-18  4:53     ` Lysenko, Mykola
2016-02-23  3:09     ` Lysenko, Mykola
2016-05-12 22:41       ` Grodzovsky, Andrey
2016-06-15  3:49         ` Dave Airlie
2016-06-15  4:14           ` Dave Airlie
2017-01-25 17:16             ` Krzysztof Nowicki
2017-01-25 17:24               ` Alex Deucher
2017-01-25 18:32                 ` Harry Wentland
2017-01-25 22:46                   ` Alex Deucher
2017-01-25 23:07                     ` Harry Wentland
2017-01-27 18:21                 ` Krzysztof Nowicki
2016-01-22 22:07 ` [PATCH 4/5] drm/dp/mst: move GUID storage from mgr, port to only mst branch Harry Wentland
2016-01-22 22:07 ` Harry Wentland [this message]
2016-01-25  4:53 ` [PATCH 0/5] Fixes for MST (daisy-chain and 4k tiles) Dave Airlie
2016-01-25 18:55   ` Wentland, Harry
2016-02-02 21:20     ` Alex Deucher
2016-02-04  0:35       ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453500449-9224-6-git-send-email-harry.wentland@amd.com \
    --to=harry.wentland@amd.com \
    --cc=Andrey.Grodzovsky@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox