From: Lucas Stach <l.stach@pengutronix.de>
To: Russell King <linux+etnaviv@arm.linux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: [PATCH 2/2] drm/etnaviv: call correct function when trying to vmap a DMABUF
Date: Tue, 26 Jan 2016 16:45:26 +0100 [thread overview]
Message-ID: <1453823126-3899-2-git-send-email-l.stach@pengutronix.de> (raw)
In-Reply-To: <1453823126-3899-1-git-send-email-l.stach@pengutronix.de>
When trying to get the vmap address of an imported buffer, we must
call into the appropriate helper function, to allow the exporter to
establish the vmap, instead of trying to vmap the buffer on our own.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index b22712fdd31e..ce458d8473fe 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -14,6 +14,7 @@
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
+#include <linux/dma-buf.h>
#include <linux/spinlock.h>
#include <linux/shmem_fs.h>
@@ -357,8 +358,14 @@ void *etnaviv_gem_vaddr(struct drm_gem_object *obj)
{
struct etnaviv_gem_object *etnaviv_obj = to_etnaviv_bo(obj);
+ if (etnaviv_obj->vaddr)
+ return etnaviv_obj->vaddr;
+
mutex_lock(&etnaviv_obj->lock);
- if (!etnaviv_obj->vaddr) {
+ if (etnaviv_obj->base.import_attach) {
+ etnaviv_obj->vaddr =
+ dma_buf_vmap(etnaviv_obj->base.import_attach->dmabuf);
+ } else {
struct page **pages = etnaviv_gem_get_pages(etnaviv_obj);
if (IS_ERR(pages)) {
--
2.7.0.rc3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-26 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 15:45 [PATCH 1/2] drm/etnaviv: fix get pages error path in etnaviv_gem_vaddr Lucas Stach
2016-01-26 15:45 ` Lucas Stach [this message]
2016-01-26 16:48 ` [PATCH 2/2] drm/etnaviv: call correct function when trying to vmap a DMABUF Russell King - ARM Linux
2016-01-26 16:45 ` [PATCH 1/2] drm/etnaviv: fix get pages error path in etnaviv_gem_vaddr Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453823126-3899-2-git-send-email-l.stach@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=christian.gmeiner@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux+etnaviv@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).