From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: "Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Michel Dänzer" <michel.daenzer@amd.com>,
"John Stultz" <john.stultz@linaro.org>,
"Dave Airlie" <airlied@redhat.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH] Revert "drm: Don't pass negative delta to ktime_sub_ns()"
Date: Tue, 29 Mar 2016 17:22:02 +0300 [thread overview]
Message-ID: <1459261322.11316.1.camel@intel.com> (raw)
In-Reply-To: <1459249942-21589-1-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 2016-03-29 at 13:12 +0200, Daniel Vetter wrote:
> This reverts commit e91abf80a0998f326107874c88d549f94839f13c.
>
> Since
>
> commit 24e4a8c3e8868874835b0f1ad6dd417341e99822
> Author: John Stultz <john.stultz@linaro.org>
> Date: Wed Jul 16 21:03:53 2014 +0000
>
> ktime: Kill non-scalar ktime_t implementation for 2038
>
> there is no longer a 32bit version that's unsigned, and we don't have
> to jump through ridiculous hoops to make the calculations correct.
>
> I didn't look whether there's more of this pattern in the kernel.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Michel Dänzer <michel.daenzer@amd.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/drm_irq.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> index f77653562fac..4d06cf41df96 100644
> --- a/drivers/gpu/drm/drm_irq.c
> +++ b/drivers/gpu/drm/drm_irq.c
> @@ -863,10 +863,7 @@ int drm_calc_vbltimestamp_from_scanoutpos(struct
> drm_device *dev,
> /* Subtract time delta from raw timestamp to get final
> * vblank_time timestamp for end of vblank.
> */
> - if (delta_ns < 0)
> - etime = ktime_add_ns(etime, -delta_ns);
> - else
> - etime = ktime_sub_ns(etime, delta_ns);
> + etime = ktime_sub_ns(etime, delta_ns);
> *vblank_time = ktime_to_timeval(etime);
>
> DRM_DEBUG_VBL("crtc %u : v 0x%x p(%d,%d)@ %ld.%ld -> %ld.%ld
> [e %d us, %d rep]\n",b
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-29 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 11:12 [PATCH] Revert "drm: Don't pass negative delta to ktime_sub_ns()" Daniel Vetter
2016-03-29 14:22 ` Imre Deak [this message]
2016-03-30 6:30 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459261322.11316.1.camel@intel.com \
--to=imre.deak@intel.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=michel.daenzer@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox