dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH 2/4] dma-buf: headerdoc fixes
Date: Thu, 31 Mar 2016 16:26:50 -0400	[thread overview]
Message-ID: <1459456012-16248-3-git-send-email-robdclark@gmail.com> (raw)
In-Reply-To: <1459456012-16248-1-git-send-email-robdclark@gmail.com>

Apparently nobody noticed that dma-buf.h wasn't actually pulled into
docbook build.  And as a result the headerdoc comments bitrot a bit.
Add missing params/fields.

Signed-off-by: Rob Clark <robdclark@gmail.com>
---
 include/linux/dma-buf.h | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
index f98bd70..6befeed 100644
--- a/include/linux/dma-buf.h
+++ b/include/linux/dma-buf.h
@@ -114,19 +114,24 @@ struct dma_buf_ops {
  * @file: file pointer used for sharing buffers across, and for refcounting.
  * @attachments: list of dma_buf_attachment that denotes all devices attached.
  * @ops: dma_buf_ops associated with this buffer object.
+ * @lock: used internally to serialize list manipulation, attach/detach and vmap/unmap
+ * @vmapping_counter: used internally to refcnt the vmaps
+ * @vmap_ptr: the current vmap ptr if vmapping_counter > 0
  * @exp_name: name of the exporter; useful for debugging.
  * @owner: pointer to exporter module; used for refcounting when exporter is a
  *         kernel module.
  * @list_node: node for dma_buf accounting and debugging.
  * @priv: exporter specific private data for this buffer object.
  * @resv: reservation object linked to this dma-buf
+ * @poll: for userspace poll support
+ * @cb_excl: for userspace poll support
+ * @cb_shared: for userspace poll support
  */
 struct dma_buf {
 	size_t size;
 	struct file *file;
 	struct list_head attachments;
 	const struct dma_buf_ops *ops;
-	/* mutex to serialize list manipulation, attach/detach and vmap/unmap */
 	struct mutex lock;
 	unsigned vmapping_counter;
 	void *vmap_ptr;
@@ -190,9 +195,11 @@ struct dma_buf_export_info {
 
 /**
  * helper macro for exporters; zeros and fills in most common values
+ *
+ * @name: export-info name
  */
-#define DEFINE_DMA_BUF_EXPORT_INFO(a)	\
-	struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME, \
+#define DEFINE_DMA_BUF_EXPORT_INFO(name)	\
+	struct dma_buf_export_info name = { .exp_name = KBUILD_MODNAME, \
 					 .owner = THIS_MODULE }
 
 /**
-- 
2.5.5

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-03-31 20:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 20:26 [PATCH 0/4] dma-buf/reservation doc updates Rob Clark
2016-03-31 20:26 ` [PATCH 1/4] reservation: sprinkle some WARN_ON()s Rob Clark
2016-04-01  8:48   ` Lucas Stach
2016-04-01 14:50     ` Rob Clark
2016-04-01 14:02   ` Christian König
2016-03-31 20:26 ` Rob Clark [this message]
2016-03-31 20:26 ` [PATCH 3/4] reservation: add headerdoc comments Rob Clark
2016-03-31 20:26 ` [PATCH 4/4] doc: update/fixup dma-buf related DocBook Rob Clark
2016-04-01 14:07 ` [PATCH 0/4] dma-buf/reservation doc updates Alex Deucher
2016-04-01 15:20   ` Sumit Semwal
2016-06-04 12:21     ` Daniel Vetter
2016-06-05 11:17       ` Sumit Semwal
2016-06-05 17:18         ` Daniel Vetter
2016-06-06  4:41           ` Sumit Semwal
     [not found] <Message-Id: <1459456012-16248-2-git-send-email-robdclark@gmail.com>
2016-04-08  0:52 ` [PATCH] reservation: sprinkle some WARN_ON()s Rob Clark
2016-06-04 12:52   ` Daniel Vetter
2016-06-04 15:47     ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459456012-16248-3-git-send-email-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox