[PATCH v2] libdrm/fourcc: Add formats R8, RG88, GR88, NV24, NV42

[PATCH v2] libdrm/fourcc: Add formats R8, RG88, GR88, NV24, NV42

[Dongseong Hwang]

Produced from headers_install of 9dabb0053b63bc32ab6ad5d13209d1e43395313f
(drm-intel-nightly) in the kernel.

ChromeOS will use new format to optimize video decoding.

CC: Stéphane Marchesin <marcheu@chromium.org>
CC: Daniele Castagna <dcastagna@chromium.org>
CC: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Rainer Hochecker <rainer.hochecker@onlinehome.de>
Cc: Benjamin Widawsky <benjamin.widawsky@intel.com>
CC: Chad Versace <chad.versace@intel.com>
Signed-off-by: Dongseong Hwang <dongseong.hwang@intel.com>
---
 include/drm/drm_fourcc.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
index e741b09..bf68099 100644
--- a/include/drm/drm_fourcc.h
+++ b/include/drm/drm_fourcc.h
@@ -34,6 +34,13 @@
 /* color index */
 #define DRM_FORMAT_C8		fourcc_code('C', '8', ' ', ' ') /* [7:0] C */
 
+/* 8 bpp Red */
+#define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
+
+/* 16 bpp RG */
+#define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
+#define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
+
 /* 8 bpp RGB */
 #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
 #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
@@ -106,6 +113,8 @@
 #define DRM_FORMAT_NV21		fourcc_code('N', 'V', '2', '1') /* 2x2 subsampled Cb:Cr plane */
 #define DRM_FORMAT_NV16		fourcc_code('N', 'V', '1', '6') /* 2x1 subsampled Cr:Cb plane */
 #define DRM_FORMAT_NV61		fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */
+#define DRM_FORMAT_NV24		fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */
+#define DRM_FORMAT_NV42		fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */
 
 /*
  * 3 plane YCbCr
@@ -216,7 +225,7 @@
  * - multiple of 128 pixels for the width
  * - multiple of  32 pixels for the height
  *
- * For more information: see http://linuxtv.org/downloads/v4l-dvb-apis/re32.html
+ * For more information: see https://linuxtv.org/downloads/v4l-dvb-apis/re32.html
  */
 #define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE	fourcc_mod_code(SAMSUNG, 1)
 
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2] libdrm/fourcc: Add formats R8, RG88, GR88, NV24, NV42

[Emil Velikov]

On 21 April 2016 at 18:46, Dongseong Hwang <dongseong.hwang@intel.com> wrote:
> Produced from headers_install of 9dabb0053b63bc32ab6ad5d13209d1e43395313f
> (drm-intel-nightly) in the kernel.
>
> ChromeOS will use new format to optimize video decoding.
>
Did you check before sending the patch out ?
As mentioned over IRC a few times - there's no need for the
update.danvet already sorted it out.

Also, I realise that CrOS development is quite high paced, although
some of us prefer quality over quantity. Meaning: don't send multiple
emails (spam?) if you have not covered (ideally) all the concerns
mentioned. Not doing so is one of the ways to alienate developers.

Pretty please ?

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] libdrm/fourcc: Add formats R8, RG88, GR88, NV24, NV42

[Hwang, Dongseong]

[-- Attachment #1.1: Type: text/plain, Size: 1296 bytes --]

I incorrectly interpreted your comments. I thought you want me to reply
every feedback.
It's first trial for me to contribute on linux. sorry for lots of noise.
I've learnt linux practice. next time it will be more smooth.
My undesirable behavior doesn't represent CrOS development. CrOS
development keeps in mind of product, so also prefers quality and
robustness.

I checked the change is already landed. Close this patch as WontFix.

Thanks you for good guidance.
Dongseong

On Thu, Apr 21, 2016 at 8:56 PM, Emil Velikov <emil.l.velikov@gmail.com>
wrote:

> On 21 April 2016 at 18:46, Dongseong Hwang <dongseong.hwang@intel.com>
> wrote:
> > Produced from headers_install of 9dabb0053b63bc32ab6ad5d13209d1e43395313f
> > (drm-intel-nightly) in the kernel.
> >
> > ChromeOS will use new format to optimize video decoding.
> >
> Did you check before sending the patch out ?
> As mentioned over IRC a few times - there's no need for the
> update.danvet already sorted it out.
>
> Also, I realise that CrOS development is quite high paced, although
> some of us prefer quality over quantity. Meaning: don't send multiple
> emails (spam?) if you have not covered (ideally) all the concerns
> mentioned. Not doing so is one of the ways to alienate developers.
>
> Pretty please ?
>
> Thanks
> Emil
>

[-- Attachment #1.2: Type: text/html, Size: 1896 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel