From: Tobias Frost <tobi@frost.de>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Gary Wong <gtw@gnu.org>, ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: libdrm: Patch to compile on hurd.
Date: Sun, 24 Apr 2016 10:00:10 +0200 [thread overview]
Message-ID: <1461484810.31832.5.camel@frost.de> (raw)
In-Reply-To: <CACvgo50tF4GGu2uEjEpKXTwe+YWiWA5DF0GD7kXCj=M=-dE=6A@mail.gmail.com>
Hi Emil,
Am Donnerstag, den 21.04.2016, 13:33 +0100 schrieb Emil Velikov:
> Hi Tobias,
>
> On 21 April 2016 at 06:30, Tobias Frost <tobi@frost.de> wrote:
> > Hallo,
> >
> > attached is a patch that makes libdrm compile on hurd.
> >
> Thanks for the patch.
>
> > (Note: I intentionally said compile, as I have no way to see if it
> > actually works there.)
> >
> Step one is actually making it build and step two involves testing it ;-)
> I've CC'ed Gary Wong, a gnu developer who has sent patches about mesa
> in the past.
>
> > The patch is created in a way to be neutral on all other archs;
> > it is mostly about PATH_MAX, which does not exist on that arch.
> >
> > Maybe you find the patch useful.
> >
> Sure do, just a few suggestions.
>
> Can you please split out the include/drm/* change to a separate patch
> and base it against the kernel UAPI headers.
I might need more instructions about this.. I'm unsure which repository
I should use as base...
> On the PATH_MAX front, please drop the whitespace change, and define
> PATH_MAX at top level, rather than using MY_PATH_MAX throughout the
> code.
> Please CC me on the updated patches and please send them via git
> send-email.
On the way...
(the include/drm/* stuff is against trunk of the git repo, in the hope
that this is what you need -- see above)
> Thanks
> Emil
--
tobi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-24 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 5:30 libdrm: Patch to compile on hurd Tobias Frost
2016-04-21 12:33 ` Emil Velikov
2016-04-24 8:00 ` Tobias Frost [this message]
2016-04-24 7:57 ` [PATCH] Workaround for systems that does not have PATH_MAX, like hurd Tobias Frost
2016-04-24 20:03 ` Emil Velikov
2016-04-24 8:09 ` libdrm: Patch to compile on hurd -- includes in drm.h Tobias Frost
2016-04-24 8:09 ` [PATCH] On hurd other includes are required to compile Tobias Frost
2016-04-24 20:20 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461484810.31832.5.camel@frost.de \
--to=tobi@frost.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gtw@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).