From: Mario Kleiner <mario.kleiner.de@gmail.com>
To: eric@anholt.net
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 1/2] drm/vc4: Fix get_vblank_counter with proper no-op for Linux 4.4+
Date: Fri, 6 May 2016 19:26:05 +0200 [thread overview]
Message-ID: <1462555566-27612-2-git-send-email-mario.kleiner.de@gmail.com> (raw)
In-Reply-To: <1462555566-27612-1-git-send-email-mario.kleiner.de@gmail.com>
get_vblank_counter hooked up to drm_vblank_count() which alway was
non-sensical but didn't hurt in the past. Since Linux 4.4 it
triggers a WARN_ON_ONCE in drm_update_vblank_count on first vblank
irq disable, so fix it by hooking to drm_vblank_no_hw_counter().
Tested against Raspian kernel 4.4.8 tree on RPi 2B.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: Eric Anholt <eric@anholt.net>
---
drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index b7d2ff0..962d0d7 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -90,7 +90,7 @@ static struct drm_driver vc4_drm_driver = {
.enable_vblank = vc4_enable_vblank,
.disable_vblank = vc4_disable_vblank,
- .get_vblank_counter = drm_vblank_count,
+ .get_vblank_counter = drm_vblank_no_hw_counter,
#if defined(CONFIG_DEBUG_FS)
.debugfs_init = vc4_debugfs_init,
--
2.7.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-05-06 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 17:26 Small vc4 kms fixes and some questions Mario Kleiner
2016-05-06 17:26 ` Mario Kleiner [this message]
2016-05-10 0:42 ` [PATCH 1/2] drm/vc4: Fix get_vblank_counter with proper no-op for Linux 4.4+ Eric Anholt
2016-05-06 17:26 ` [PATCH 2/2] drm/vc4: Fix drm_vblank_put/get imbalance in page flip path Mario Kleiner
2016-05-09 19:38 ` Small vc4 kms fixes and some questions Eric Anholt
2016-05-13 2:16 ` Mario Kleiner
2016-05-13 18:51 ` Eric Anholt
2016-05-20 1:40 ` Mario Kleiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462555566-27612-2-git-send-email-mario.kleiner.de@gmail.com \
--to=mario.kleiner.de@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).