dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [GIT PULL] imx-drm module autoloading fix
Date: Tue, 17 May 2016 10:56:14 +0200	[thread overview]
Message-ID: <1463475374.4168.40.camel@pengutronix.de> (raw)
In-Reply-To: <CAPM=9twhKcEjCFsXUJtwJLHLDLGqKjBSBdADntTEGHirR6VHuA@mail.gmail.com>

Am Donnerstag, den 05.05.2016, 10:37 +1000 schrieb Dave Airlie:
> On 3 May 2016 at 18:48, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > Hi Dave,
> >
> > here is the imx-ipuv3-crtc autoloading fix so you don't have to revert commit
> > 304e6be652e2 ("gpu: ipu-v3: Assign of_node of child platform devices to
> > corresponding ports").
> 
> I didn't pull this, but I cherry-picked the patch out and added stable
> tags on it
> since Denis wanted to get it into 4.4 and above.

It turns out this patch breaks probing for the built-in case [1]. As a
result, imx-drm probing is broken in v4.6. I have sent a patch [2] to
fix the issue by matching the crtc components not against dev->of_node
but against an of_node pointer stored in platform data.

[1] http://comments.gmane.org/gmane.linux.ports.arm.kernel/499839
    Message-ID: <20160513123336.6996dd89@ipc1.ka-ro>
[2] https://patchwork.kernel.org/patch/9081661/
    Message-ID: <1463062124-20256-1-git-send-email-p.zabel@pengutronix.de>

Could we apply that or revert commit 407c9eba7897 ("drm/imx: Remove
of_node assignment from ipuv3-crtc driver probe") for the time being?

Either way, applying this patch without doing either of the two will
break imx-drm probing in v4.4 and v4.5 stable, too.

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-05-17  8:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03  8:48 [GIT PULL] imx-drm module autoloading fix Philipp Zabel
2016-05-05  0:37 ` Dave Airlie
2016-05-06 15:04   ` Philipp Zabel
2016-05-17  8:56   ` Philipp Zabel [this message]
2016-05-17 10:51     ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463475374.4168.40.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox