From: Alex Deucher <alexdeucher@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>, Monk Liu <Monk.Liu@amd.com>
Subject: [PATCH 11/13] drm/amdgpu: fix cik sdma ucode memleak
Date: Thu, 2 Jun 2016 10:39:11 -0400 [thread overview]
Message-ID: <1464878353-16836-12-git-send-email-alexander.deucher@amd.com> (raw)
In-Reply-To: <1464878353-16836-1-git-send-email-alexander.deucher@amd.com>
From: Monk Liu <Monk.Liu@amd.com>
Signed-off-by: Monk Liu <Monk.Liu@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c
index 0079916..9dc4e24 100644
--- a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c
+++ b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c
@@ -66,6 +66,16 @@ MODULE_FIRMWARE("radeon/mullins_sdma1.bin");
u32 amdgpu_cik_gpu_check_soft_reset(struct amdgpu_device *adev);
+
+static void cik_sdma_free_microcode(struct amdgpu_device *adev)
+{
+ int i;
+ for (i = 0; i < adev->sdma.num_instances; i++) {
+ release_firmware(adev->sdma.instance[i].fw);
+ adev->sdma.instance[i].fw = NULL;
+ }
+}
+
/*
* sDMA - System DMA
* Starting with CIK, the GPU has new asynchronous
@@ -1005,6 +1015,7 @@ static int cik_sdma_sw_fini(void *handle)
for (i = 0; i < adev->sdma.num_instances; i++)
amdgpu_ring_fini(&adev->sdma.instance[i].ring);
+ cik_sdma_free_microcode(adev);
return 0;
}
--
2.5.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-02 14:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 14:39 [PATCH 00/13] Fix memory and firmware leaks Alex Deucher
2016-06-02 14:39 ` [PATCH 01/13] drm/amdgpu: fix mem leak in smumgr Alex Deucher
2016-06-02 14:39 ` [PATCH 02/13] drm/amdgpu: fix mem leak in pplib/hwmgr Alex Deucher
2016-06-02 14:39 ` [PATCH 03/13] drm/amdgpu: fix mem leak in atombios Alex Deucher
2016-06-02 14:39 ` [PATCH 04/13] drm/amdgpu: fix memleak in pptable_init Alex Deucher
2016-06-02 14:39 ` [PATCH 05/13] drm/amdgpu: fix missing free wb for cond_exec Alex Deucher
2016-06-02 14:39 ` [PATCH 06/13] drm/amdgpu: fix gfx8 ucode mem leak Alex Deucher
2016-06-02 14:39 ` [PATCH 07/13] drm/amdgpu: fix gfx 7 " Alex Deucher
2016-06-02 14:39 ` [PATCH 08/13] drm/amdgpu: fix uvd fini " Alex Deucher
2016-06-02 14:39 ` [PATCH 09/13] drm/amdgpu: fix sdma3 ucode " Alex Deucher
2016-06-02 14:39 ` [PATCH 10/13] drm/amdgpu: fix sdma24 " Alex Deucher
2016-06-02 14:39 ` Alex Deucher [this message]
2016-06-02 14:39 ` [PATCH 12/13] drm/amdgpu: fix fiji smu fini " Alex Deucher
2016-06-02 14:39 ` [PATCH 13/13] drm/amdgpu: fix tonga smu_fini " Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464878353-16836-12-git-send-email-alexander.deucher@amd.com \
--to=alexdeucher@gmail.com \
--cc=Monk.Liu@amd.com \
--cc=alexander.deucher@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox