From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/virtio: Don't reinvent a flipping wheel
Date: Mon, 13 Jun 2016 11:20:29 +0200 [thread overview]
Message-ID: <1465809629.32424.58.camel@redhat.com> (raw)
In-Reply-To: <20160610152017.GJ3363@phenom.ffwll.local>
On Fr, 2016-06-10 at 17:20 +0200, Daniel Vetter wrote:
> On Fri, Jun 10, 2016 at 12:07:53AM +0200, Daniel Vetter wrote:
> > Now that the core helpers support nonblocking atomic commits there's
> > no need to invent that wheel separately (instead of fixing the bug in
> > the atomic implementation of virtio, as it should have been done!).
> >
> > v2: Rebased on top of
> >
> > commit e7cf0963f816fa44190caaf51aeffaa614c340c6
> > Author: Gerd Hoffmann <kraxel@redhat.com>
> > Date: Tue May 31 08:50:47 2016 +0200
> >
> > virtio-gpu: add atomic_commit function
> >
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Tested-by: Gerd Hoffmann <kraxel@redhat.com> (v1)
> > Reviewed-by: Gerd Hoffmann <kraxel@redhat.com> (v1)
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> Gerd, can you pls retest? I think due to your change in the above
> referenced commit to switch to active_only=true in commit_planes() this is
> now broken.
Yes, probably it'll break things.
Any branch I can test? Your "stuff" branch seems to not yet have the
commit above.
I guess virtio-gpu should switch over to override .atomic_commit_tail
instead of .atomic_commit?
cheers,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-13 9:20 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 12:18 [PATCH 01/27] drm/atomic-helper: Massage swap_state signature somewhat Daniel Vetter
2016-06-08 12:18 ` [PATCH 02/27] drm/arc: Nuke event_list Daniel Vetter
2016-06-08 14:13 ` Maarten Lankhorst
2016-06-08 12:18 ` [PATCH 03/27] drm/arc: Actually bother with handling atomic events Daniel Vetter
2016-06-08 14:14 ` Maarten Lankhorst
2016-06-08 14:30 ` Daniel Vetter
2016-06-09 10:54 ` Alexey Brodkin
2016-06-09 12:26 ` Daniel Vetter
2016-06-09 12:48 ` Alexey Brodkin
2016-06-09 13:23 ` Daniel Vetter
2016-06-09 13:27 ` Alexey Brodkin
2016-06-09 13:52 ` Daniel Vetter
2016-06-09 14:29 ` Alexey Brodkin
2016-06-09 14:31 ` Daniel Vetter
2016-06-09 14:37 ` Daniel Vetter
2016-06-10 13:23 ` Alexey Brodkin
2016-06-10 14:19 ` Daniel Vetter
2016-06-10 14:54 ` Daniel Vetter
2016-06-10 15:01 ` Alexey Brodkin
2016-06-10 15:09 ` Daniel Vetter
2016-06-10 15:16 ` Alexey Brodkin
2016-06-08 12:18 ` [PATCH 04/27] drm/fsl-du: Implement some semblance of vblank event handling Daniel Vetter
2016-06-08 14:15 ` Maarten Lankhorst
2016-06-08 12:18 ` [PATCH 05/27] drm/hisilicon: " Daniel Vetter
2016-06-08 14:17 ` Maarten Lankhorst
2016-06-08 14:32 ` Daniel Vetter
2016-06-08 12:18 ` [PATCH 06/27] drm/sun4i: " Daniel Vetter
2016-06-09 9:03 ` Maarten Lankhorst
2017-01-02 12:23 ` Laurent Pinchart
2016-06-08 12:18 ` [PATCH 07/27] drm/atomic: kerneldoc for drm_atomic_crtc_needs_modeset Daniel Vetter
2016-06-08 14:11 ` Liviu Dudau
2016-06-09 9:03 ` Maarten Lankhorst
2016-06-08 12:19 ` [PATCH 08/27] drm/atomic: Add struct drm_crtc_commit to track async updates Daniel Vetter
2016-06-08 14:41 ` Maarten Lankhorst
2016-06-09 10:09 ` Liviu Dudau
2016-06-08 12:19 ` [PATCH 09/27] drm/atomic-helper: roll out commit synchronization Daniel Vetter
2016-06-08 14:40 ` Maarten Lankhorst
2016-06-08 15:15 ` [PATCH] " Daniel Vetter
2017-01-02 12:09 ` Laurent Pinchart
2017-01-04 8:49 ` Daniel Vetter
2016-06-09 14:22 ` [PATCH 09/27] " Maarten Lankhorst
2016-06-08 12:19 ` [PATCH 10/27] drm/atomic-helper: nonblocking commit support Daniel Vetter
2016-06-08 14:44 ` Maarten Lankhorst
2016-06-08 15:05 ` Daniel Vetter
2016-06-08 15:54 ` Chris Wilson
2016-06-08 16:19 ` Daniel Vetter
2016-06-08 16:22 ` Daniel Vetter
2016-06-08 12:19 ` [PATCH 11/27] drm/arc: Implement nonblocking commit correctly Daniel Vetter
2016-06-08 14:27 ` Maarten Lankhorst
2016-06-08 12:19 ` [PATCH 12/27] drm/hdlcd: Use helper support for nonblocking commits Daniel Vetter
2016-06-08 12:19 ` [PATCH 13/27] drm/i915: Signal drm events for atomic Daniel Vetter
2016-06-08 14:25 ` Maarten Lankhorst
2016-06-08 12:19 ` [PATCH 14/27] drm/i915: Roll out the helper nonblock tracking Daniel Vetter
2016-06-09 14:01 ` Maarten Lankhorst
2016-06-08 12:19 ` [PATCH 15/27] drm/i915: nonblocking commit Daniel Vetter
2016-06-09 14:03 ` Maarten Lankhorst
2016-06-09 14:40 ` Daniel Vetter
2016-06-08 12:19 ` [PATCH 16/27] drm/i915: Use atomic commits for legacy page_flips Daniel Vetter
2016-06-08 14:24 ` Chris Wilson
2016-06-08 14:34 ` Daniel Vetter
2016-06-08 12:19 ` [PATCH 17/27] drm/i915: Move fb_bits updating later in atomic_commit Daniel Vetter
2016-06-08 12:19 ` [PATCH 18/27] drm/rockchip: Disarm vop->is_enabled Daniel Vetter
2016-06-08 12:19 ` [PATCH 19/27] drm/rockchip: Fix crtc_state->event signalling Daniel Vetter
2016-06-08 12:19 ` [PATCH 20/27] drm/rockchip: convert to helper nonblocking atomic commit Daniel Vetter
2016-06-08 12:19 ` [PATCH 21/27] drm/rockchip: Nuke pending event handling in preclose Daniel Vetter
2016-06-10 15:21 ` Daniel Vetter
2016-06-08 12:19 ` [PATCH 22/27] drm/virtio: Don't reinvent a flipping wheel Daniel Vetter
2016-06-09 22:07 ` [PATCH] " Daniel Vetter
2016-06-10 15:20 ` Daniel Vetter
2016-06-13 9:20 ` Gerd Hoffmann [this message]
2016-06-13 13:34 ` Daniel Vetter
2016-06-14 14:25 ` Gerd Hoffmann
2016-06-14 14:33 ` Daniel Vetter
2016-06-08 12:19 ` [PATCH 23/27] drm: Replace fb_helper->atomic with mode_config->atomic_commit Daniel Vetter
2016-06-08 12:36 ` Boris Brezillon
2016-06-12 9:01 ` Ying Liu
2016-06-13 7:58 ` Daniel Vetter
2016-06-13 9:26 ` Ying Liu
2016-06-13 14:01 ` Daniel Vetter
2016-06-20 5:55 ` Ying Liu
2016-06-20 13:26 ` Daniel Vetter
2016-06-08 12:19 ` [PATCH 24/27] drm: Resurrect atomic rmfb code Daniel Vetter
2016-07-13 10:15 ` Maarten Lankhorst
2016-07-13 10:56 ` Daniel Vetter
2016-06-08 12:19 ` [PATCH 25/27] drm/sti: Don't call drm_helper_disable_unused_functions Daniel Vetter
2016-06-08 12:19 ` [PATCH 26/27] drm/crtc-helper: disable_unused_functions really isn't for atomic Daniel Vetter
2016-06-08 22:36 ` Laurent Pinchart
2016-06-09 8:26 ` Daniel Vetter
2016-06-21 9:12 ` Laurent Pinchart
2016-06-21 9:46 ` Daniel Vetter
2016-06-09 22:14 ` [PATCH] drm/omapdrm: don't call drm_helper_disable_unused_functions Daniel Vetter
2016-06-09 22:50 ` Laurent Pinchart
2016-06-10 6:24 ` Tomi Valkeinen
2016-06-10 6:26 ` Tomi Valkeinen
2016-06-21 8:02 ` Daniel Vetter
2016-06-08 12:19 ` [PATCH 27/27] drm/atomic-helper: Annotate a bunch more RETURNS: sections Daniel Vetter
2016-06-08 14:11 ` [PATCH 01/27] drm/atomic-helper: Massage swap_state signature somewhat Maarten Lankhorst
2016-06-09 22:06 ` [PATCH] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465809629.32424.58.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox