From: Philipp Zabel <p.zabel@pengutronix.de>
To: Dave Airlie <airlied@gmail.com>
Cc: linux-mediatek@lists.infradead.org,
dri-devel <dri-devel@lists.freedesktop.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [GIT PULL] drm/mediatek: MT8173 HDMI support
Date: Thu, 16 Jun 2016 16:41:34 +0200 [thread overview]
Message-ID: <1466088094.3343.36.camel@pengutronix.de> (raw)
In-Reply-To: <CAPM=9tyMpNpzq9m4tJBe-zFzmsaRxFHYV20yv5yWmsrGeuQcqw@mail.gmail.com>
Am Donnerstag, den 16.06.2016, 06:19 +1000 schrieb Dave Airlie:
> On 13 June 2016 at 19:44, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > Hi Dave,
> >
> > please consider merging this tag, which contains the v16 MT8173 HDMI
> > patches I sent on 2016-05-26, rebased onto v4.7-rc2. There have been no
> > further comments.
>
> arm32 build
> DTC drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c:
> In function ‘mtk_hdmi_ddc_probe’:
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c:322:111:
> warning: format ‘%llx’ expects argument of type ‘long long unsigned
> int’, but argument 4 has type ‘resource_size_t {aka unsigned int}’
> [-Wformat=]
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c:322:111:
> warning: format ‘%llx’ expects argument of type ‘long long unsigned
> int’, but argument 5 has type ‘resource_size_t {aka unsigned int}’
> [-Wformat=]
>
> Please fix that and resend.
> Dave.
I'll fix it up as follows and resend:
----------8<----------
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
index c24bbc4..33c9e1b 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
@@ -319,8 +319,8 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev)
dev_dbg(dev, "ddc->adap: %p\n", &ddc->adap);
dev_dbg(dev, "ddc->clk: %p\n", ddc->clk);
- dev_dbg(dev, "physical adr: 0x%llx, end: 0x%llx\n", mem->start,
- mem->end);
+ dev_dbg(dev, "physical adr: %pa, end: %pa\n", &mem->start,
+ &mem->end);
return 0;
---------->8----------
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-06-16 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 9:44 [GIT PULL] drm/mediatek: MT8173 HDMI support Philipp Zabel
2016-06-15 20:19 ` Dave Airlie
2016-06-16 14:41 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466088094.3343.36.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox