dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: dri-devel@lists.freedesktop.org
Cc: marcheu@google.com, Daniel Stone <daniels@collabora.com>,
	seanpaul@google.com, Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	John Harrison <John.C.Harrison@Intel.com>,
	m.chehab@samsung.com
Subject: [RFC v2 0/3] dma-buf/sync_file: rework fences on struct sync_file
Date: Mon, 27 Jun 2016 16:29:19 -0300	[thread overview]
Message-ID: <1467055762-25881-1-git-send-email-gustavo@padovan.org> (raw)

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Hi all,

This is an attempt to improve fence support on Sync File. The basic idea
is to have only sync_file->fence and store all fences there, either as
normal fences or fence_arrays. That way we can remove some potential
duplication when using fence_array with sync_file: the duplication of the array
of fences and the duplication of fence_add_callback() for all fences.

Now when creating a new sync_file during the merge process sync_file_set_fence()
will set sync_file->fence based on the number of fences for that sync_file. If
there is more than one fence a fence_array is created. One important advantage
approach is that we only add one fence callback now, no matter how many fences
there are in a sync_file - the individual callbacks are added by fence_array.

Please review! Thanks!

	Gustavo

Changes since v1 (Comments from Chris Wilson and Christian König):
	- Not using fence_ops anymore.
	- fence_is_array() was created to differentiate fence from fence_array
	- fence_array_teardown() is now exported and used under fence_is_array()
	- struct sync_file lost num_fences member

Gustavo Padovan (3):
  dma-buf/fence-array: add fence_is_array()
  dma-buf/fence-array: add fence_array_teardown()
  dma-buf/sync_file: rework fence storage in struct file

 drivers/dma-buf/fence-array.c        |  25 ++++++
 drivers/dma-buf/sync_file.c          | 148 +++++++++++++++++++++++------------
 drivers/staging/android/sync_debug.c |   9 ++-
 include/linux/fence-array.h          |  11 +++
 include/linux/sync_file.h            |  15 ++--
 5 files changed, 147 insertions(+), 61 deletions(-)

-- 
2.5.5

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2016-06-27 19:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 19:29 Gustavo Padovan [this message]
2016-06-27 19:29 ` [RFC v2 1/3] dma-buf/fence-array: add fence_is_array() Gustavo Padovan
2016-06-27 19:29 ` [RFC v2 2/3] dma-buf/fence-array: add fence_array_teardown() Gustavo Padovan
2016-06-28  9:56   ` Christian König
2016-06-28 14:17     ` Gustavo Padovan
2016-06-28 15:05       ` Christian König
2016-06-28 15:17         ` Gustavo Padovan
2016-06-27 19:29 ` [RFC v2 3/3] dma-buf/sync_file: rework fence storage in struct file Gustavo Padovan
2016-06-28  8:02   ` Chris Wilson
2016-06-28 14:25     ` Gustavo Padovan
2016-06-28 15:09       ` Chris Wilson
2016-06-28 15:27         ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467055762-25881-1-git-send-email-gustavo@padovan.org \
    --to=gustavo@padovan.org \
    --cc=John.C.Harrison@Intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=marcheu@google.com \
    --cc=seanpaul@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).