From: Fabio Estevam <festevam@gmail.com>
To: p.zabel@pengutronix.de
Cc: Fabio Estevam <fabio.estevam@nxp.com>, dri-devel@lists.freedesktop.org
Subject: [PATCH 3/3] drm/imx: remove unneeded 'or' operation
Date: Sat, 9 Jul 2016 18:57:44 -0300 [thread overview]
Message-ID: <1468101464-428-3-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1468101464-428-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@nxp.com>
There is no need for doing an extra 'or' operation when reading
the return value from of_property_read_u32().
Just do a simple read instead.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/imx/imx-tve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index a52939c..2cf0631 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -594,7 +594,7 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data)
return ret;
}
- ret |= of_property_read_u32(np, "fsl,vsync-pin",
+ ret = of_property_read_u32(np, "fsl,vsync-pin",
&tve->vsync_pin);
if (ret < 0) {
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-09 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 21:57 [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage() Fabio Estevam
2016-07-09 21:57 ` [PATCH 2/3] drm/imx: fix the error message Fabio Estevam
2016-07-09 21:57 ` Fabio Estevam [this message]
2016-07-11 10:26 ` [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage() Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468101464-428-3-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@nxp.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox