From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Lothar=20Wa=C3=9Fmann?= Subject: [PATCHv4 1/3] drm/imx: parallel-display: check return code from of_get_drm_display_mode() Date: Tue, 12 Jul 2016 15:30:01 +0200 Message-ID: <1468330203-29150-2-git-send-email-LW@KARO-electronics.de> References: <1468330203-29150-1-git-send-email-LW@KARO-electronics.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1468330203-29150-1-git-send-email-LW@KARO-electronics.de> Sender: linux-kernel-owner@vger.kernel.org To: David Airlie , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter Cc: =?UTF-8?q?Lothar=20Wa=C3=9Fmann?= List-Id: dri-devel@lists.freedesktop.org of_get_drm_display_mode() may fail. Check its return code and bail out on error. Signed-off-by: Lothar Wa=C3=9Fmann --- drivers/gpu/drm/imx/parallel-display.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/i= mx/parallel-display.c index 2d1fd02..4b2ec5d 100644 --- a/drivers/gpu/drm/imx/parallel-display.c +++ b/drivers/gpu/drm/imx/parallel-display.c @@ -69,10 +69,16 @@ static int imx_pd_connector_get_modes(struct drm_co= nnector *connector) =20 if (np) { struct drm_display_mode *mode =3D drm_mode_create(connector->dev); + int ret; =20 if (!mode) return -EINVAL; - of_get_drm_display_mode(np, &imxpd->mode, OF_USE_NATIVE_MODE); + + ret =3D of_get_drm_display_mode(np, &imxpd->mode, + OF_USE_NATIVE_MODE); + if (ret) + return ret; + drm_mode_copy(mode, &imxpd->mode); mode->type |=3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, drm_mode_probed_add(connector, mode); --=20 2.1.4