From: Brian Starkey <brian.starkey@arm.com>
To: dri-devel@lists.freedesktop.org
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/i2c: tda998x: don't register the connector
Date: Mon, 25 Jul 2016 11:55:48 +0100 [thread overview]
Message-ID: <1469444148-19003-1-git-send-email-brian.starkey@arm.com> (raw)
The connector shouldn't be registered until the rest of the whole device
is set up, so that consistent state is presented to userspace.
As drm_dev_register() now registers all of the connectors anyway,
there's no need to explicitly do it in individual drivers so remove
the calls to drm_connector_register()/drm_connector_unregister().
This allows componentised drivers to use tda998x without having racy
initialisation.
Signed-off-by: Brian Starkey <brian.starkey@arm.com>
Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index f4315bc..6e6fca2 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1369,7 +1369,6 @@ const struct drm_connector_helper_funcs tda998x_connector_helper_funcs = {
static void tda998x_connector_destroy(struct drm_connector *connector)
{
- drm_connector_unregister(connector);
drm_connector_cleanup(connector);
}
@@ -1441,16 +1440,10 @@ static int tda998x_bind(struct device *dev, struct device *master, void *data)
if (ret)
goto err_connector;
- ret = drm_connector_register(&priv->connector);
- if (ret)
- goto err_sysfs;
-
drm_mode_connector_attach_encoder(&priv->connector, &priv->encoder);
return 0;
-err_sysfs:
- drm_connector_cleanup(&priv->connector);
err_connector:
drm_encoder_cleanup(&priv->encoder);
err_encoder:
@@ -1463,7 +1456,6 @@ static void tda998x_unbind(struct device *dev, struct device *master,
{
struct tda998x_priv *priv = dev_get_drvdata(dev);
- drm_connector_unregister(&priv->connector);
drm_connector_cleanup(&priv->connector);
drm_encoder_cleanup(&priv->encoder);
tda998x_destroy(priv);
--
1.7.9.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2016-07-25 10:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 10:55 Brian Starkey [this message]
2016-07-25 12:25 ` [PATCH] drm/i2c: tda998x: don't register the connector Russell King - ARM Linux
2016-07-25 12:54 ` Brian Starkey
2016-07-25 15:08 ` Daniel Vetter
2016-08-08 16:04 ` Brian Starkey
2016-08-09 6:07 ` Daniel Vetter
2016-08-09 22:48 ` Russell King - ARM Linux
2016-09-21 8:57 ` Brian Starkey
2016-09-21 16:28 ` Russell King - ARM Linux
2016-09-22 10:39 ` Brian Starkey
2016-09-22 10:51 ` Russell King - ARM Linux
2016-09-22 11:22 ` Sean Paul
2016-09-22 11:28 ` Daniel Vetter
2016-09-22 13:38 ` Brian Starkey
2016-09-22 14:24 ` Russell King - ARM Linux
2016-09-22 12:09 ` Russell King - ARM Linux
2016-09-22 12:32 ` Sean Paul
2016-09-22 12:40 ` Russell King - ARM Linux
2016-09-23 7:07 ` Daniel Vetter
2016-09-22 14:14 ` Brian Starkey
2016-09-23 7:05 ` Daniel Vetter
2016-09-23 7:18 ` [PATCH] Revert "drm/i2c: tda998x: don't register the connector" Sean Paul
2016-09-23 9:32 ` liviu.dudau
2016-09-23 11:05 ` Sean Paul
2016-09-23 9:34 ` [PATCH] drm/i2c: tda998x: don't register the connector Liviu Dudau
2016-09-23 10:58 ` Daniel Vetter
2016-09-23 12:22 ` Lucas Stach
2016-09-23 12:52 ` Brian Starkey
2016-09-23 13:13 ` Daniel Vetter
2016-09-23 14:05 ` Russell King - ARM Linux
2016-09-25 20:34 ` Daniel Vetter
2016-09-23 14:42 ` Brian Starkey
2016-09-25 20:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469444148-19003-1-git-send-email-brian.starkey@arm.com \
--to=brian.starkey@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).