From: Philipp Zabel <p.zabel@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH 1/5] drm/imx: don't call disable_plane in plane destroy path
Date: Mon, 29 Aug 2016 12:53:10 +0200 [thread overview]
Message-ID: <1472467990.3054.56.camel@pengutronix.de> (raw)
In-Reply-To: <1470907131-2726-1-git-send-email-l.stach@pengutronix.de>
Am Donnerstag, den 11.08.2016, 11:18 +0200 schrieb Lucas Stach:
> When the destroy path is called the plane should already be
> disabled. If not, this is a core bug and should not be worked
> around in the driver.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/gpu/drm/imx/ipuv3-plane.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c
> index 4ad67d015ec7..6cc809e1ca55 100644
> --- a/drivers/gpu/drm/imx/ipuv3-plane.c
> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c
> @@ -242,7 +242,6 @@ static void ipu_plane_destroy(struct drm_plane *plane)
>
> DRM_DEBUG_KMS("[%d] %s\n", __LINE__, __func__);
>
> - ipu_disable_plane(plane);
> drm_plane_cleanup(plane);
> kfree(ipu_plane);
> }
Applied all 5.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-08-29 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 9:18 [PATCH 1/5] drm/imx: don't call disable_plane in plane destroy path Lucas Stach
2016-08-11 9:18 ` [PATCH 2/5] drm/imx: drop deprecated load/unload drm_driver ops Lucas Stach
2016-08-11 9:18 ` [PATCH 3/5] drm/imx: don't destroy mode objects manually on driver unbind Lucas Stach
2016-08-11 9:18 ` [PATCH 4/5] drm/imx: fold ipu_plane_disable into ipu_disable_plane Lucas Stach
2016-08-11 9:18 ` [PATCH 5/5] drm/imx: add exclusive fence to plane state Lucas Stach
2016-09-19 20:48 ` Daniel Vetter
2016-09-20 7:02 ` Lucas Stach
2016-08-29 10:53 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472467990.3054.56.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).