From: Sean Paul <seanpaul@chromium.org>
To: daniel@ffwll.ch, brian.starkey@arm.com, dri-devel@lists.freedesktop.org
Cc: liviu.dudau@arm.com, linux@armlinux.org.uk
Subject: [PATCH] Revert "drm/i2c: tda998x: don't register the connector"
Date: Fri, 23 Sep 2016 00:18:12 -0700 [thread overview]
Message-ID: <1474615092-10979-1-git-send-email-seanpaul@chromium.org> (raw)
In-Reply-To: <CAKMK7uHjB8KPsaToZsgn9Hh3L4BsEBoYUZPosCsMpWW+7ie-BQ@mail.gmail.com>
This reverts commit 6a2925ea12006911c8180a89feda6d040873ed18.
commit 6a2925ea12006911c8180a89feda6d040873ed18
Author: Brian Starkey <brian.starkey@arm.com>
Date: Mon Jul 25 11:55:48 2016 +0100
drm/i2c: tda998x: don't register the connector
[seanpaul]
Patch isn't fully baked, and apparently causing issues in hdlcd. Revert
until this is sorted.
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 088900d..9798d40 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1584,6 +1584,7 @@ const struct drm_connector_helper_funcs tda998x_connector_helper_funcs = {
static void tda998x_connector_destroy(struct drm_connector *connector)
{
+ drm_connector_unregister(connector);
drm_connector_cleanup(connector);
}
@@ -1655,10 +1656,16 @@ static int tda998x_bind(struct device *dev, struct device *master, void *data)
if (ret)
goto err_connector;
+ ret = drm_connector_register(&priv->connector);
+ if (ret)
+ goto err_sysfs;
+
drm_mode_connector_attach_encoder(&priv->connector, &priv->encoder);
return 0;
+err_sysfs:
+ drm_connector_cleanup(&priv->connector);
err_connector:
drm_encoder_cleanup(&priv->encoder);
err_encoder:
@@ -1671,6 +1678,7 @@ static void tda998x_unbind(struct device *dev, struct device *master,
{
struct tda998x_priv *priv = dev_get_drvdata(dev);
+ drm_connector_unregister(&priv->connector);
drm_connector_cleanup(&priv->connector);
drm_encoder_cleanup(&priv->encoder);
tda998x_destroy(priv);
--
2.8.0.rc3.226.g39d4020
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-09-23 7:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 10:55 [PATCH] drm/i2c: tda998x: don't register the connector Brian Starkey
2016-07-25 12:25 ` Russell King - ARM Linux
2016-07-25 12:54 ` Brian Starkey
2016-07-25 15:08 ` Daniel Vetter
2016-08-08 16:04 ` Brian Starkey
2016-08-09 6:07 ` Daniel Vetter
2016-08-09 22:48 ` Russell King - ARM Linux
2016-09-21 8:57 ` Brian Starkey
2016-09-21 16:28 ` Russell King - ARM Linux
2016-09-22 10:39 ` Brian Starkey
2016-09-22 10:51 ` Russell King - ARM Linux
2016-09-22 11:22 ` Sean Paul
2016-09-22 11:28 ` Daniel Vetter
2016-09-22 13:38 ` Brian Starkey
2016-09-22 14:24 ` Russell King - ARM Linux
2016-09-22 12:09 ` Russell King - ARM Linux
2016-09-22 12:32 ` Sean Paul
2016-09-22 12:40 ` Russell King - ARM Linux
2016-09-23 7:07 ` Daniel Vetter
2016-09-22 14:14 ` Brian Starkey
2016-09-23 7:05 ` Daniel Vetter
2016-09-23 7:18 ` Sean Paul [this message]
2016-09-23 9:32 ` [PATCH] Revert "drm/i2c: tda998x: don't register the connector" liviu.dudau
2016-09-23 11:05 ` Sean Paul
2016-09-23 9:34 ` [PATCH] drm/i2c: tda998x: don't register the connector Liviu Dudau
2016-09-23 10:58 ` Daniel Vetter
2016-09-23 12:22 ` Lucas Stach
2016-09-23 12:52 ` Brian Starkey
2016-09-23 13:13 ` Daniel Vetter
2016-09-23 14:05 ` Russell King - ARM Linux
2016-09-25 20:34 ` Daniel Vetter
2016-09-23 14:42 ` Brian Starkey
2016-09-25 20:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474615092-10979-1-git-send-email-seanpaul@chromium.org \
--to=seanpaul@chromium.org \
--cc=brian.starkey@arm.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).