From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH] drm/i2c: tda998x: don't register the connector Date: Fri, 23 Sep 2016 15:22:22 +0300 Message-ID: <1474633342.2664.26.camel@pengutronix.de> References: <20160808160402.GA24667@e106950-lin.cambridge.arm.com> <20160809060724.GD6232@phenom.ffwll.local> <20160809224812.GJ1041@n2100.armlinux.org.uk> <20160921085738.GA27277@e106950-lin.cambridge.arm.com> <20160921162803.GS1041@n2100.armlinux.org.uk> <20160922103917.GA5632@e106950-lin.cambridge.arm.com> <20160922105155.GT1041@n2100.armlinux.org.uk> <20160922141404.GA5222@e106950-lin.cambridge.arm.com> <20160923093416.GU8917@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter , Liviu Dudau Cc: Linux Kernel Mailing List , dri-devel , Russell King - ARM Linux List-Id: dri-devel@lists.freedesktop.org Am Freitag, den 23.09.2016, 12:58 +0200 schrieb Daniel Vetter: > On Fri, Sep 23, 2016 at 11:34 AM, Liviu Dudau > wrote: > > > > rmmod-ing the hdlcd module generates a WARN() splat as the vsync is > > still > > enabled, but we never got the call to turn off the CRTC. Brian is > > still > > tracking through the fbdev emulation to figure out the cause for > > that. > > fbdev emulation doesn't do that for you. If you need/want to shut > down > all the crtcs on driver unload, you need to do that yourself. There's > atomic helpers to do that for you that for you. Which reminds me that my patch (drm/atomic-helper: add unlocked disable all outputs helper) to add such a helper wasn't applied. Probably my own fault by being non-responsive to Seans question. Regards, Lucas