* [PATCH] drm/bochs: mark bochs_connector_get_modes() static
@ 2016-09-25 7:25 Baoyou Xie
2016-09-26 8:52 ` Gerd Hoffmann
0 siblings, 1 reply; 5+ messages in thread
From: Baoyou Xie @ 2016-09-25 7:25 UTC (permalink / raw)
To: kraxel, airlied, daniel.vetter, alexander.deucher, treding,
boris.brezillon, CARLOS.PALMINHA, ville.syrjala, christian.koenig
Cc: dri-devel, linux-kernel, arnd, baoyou.xie, xie.baoyou, han.fei,
tang.qiang007, Baoyou Xie
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/bochs/bochs_kms.c:181:5: warning: no previous prototype for 'bochs_connector_get_modes' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/bochs/bochs_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c
index 207a2cb..0b4e5d1 100644
--- a/drivers/gpu/drm/bochs/bochs_kms.c
+++ b/drivers/gpu/drm/bochs/bochs_kms.c
@@ -178,7 +178,7 @@ static void bochs_encoder_init(struct drm_device *dev)
}
-int bochs_connector_get_modes(struct drm_connector *connector)
+static int bochs_connector_get_modes(struct drm_connector *connector)
{
int count;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/bochs: mark bochs_connector_get_modes() static
2016-09-25 7:25 [PATCH] drm/bochs: mark bochs_connector_get_modes() static Baoyou Xie
@ 2016-09-26 8:52 ` Gerd Hoffmann
2016-09-26 9:29 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2016-09-26 8:52 UTC (permalink / raw)
To: Baoyou Xie
Cc: baoyou.xie, arnd, daniel.vetter, tang.qiang007, xie.baoyou,
CARLOS.PALMINHA, dri-devel, linux-kernel, han.fei,
alexander.deucher, treding, christian.koenig
On So, 2016-09-25 at 15:25 +0800, Baoyou Xie wrote:
> -int bochs_connector_get_modes(struct drm_connector *connector)
> +static int bochs_connector_get_modes(struct drm_connector *connector)
Added to drm-qemu queue.
thanks,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bochs: mark bochs_connector_get_modes() static
2016-09-26 8:52 ` Gerd Hoffmann
@ 2016-09-26 9:29 ` Daniel Vetter
2016-09-26 10:20 ` Gerd Hoffmann
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2016-09-26 9:29 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Baoyou Xie, Arnd Bergmann, tang.qiang007, Baoyou Xie,
Carlos Palminha, dri-devel, Linux Kernel Mailing List, baoyou.xie,
han.fei, alexander.deucher@amd.com, Thierry Reding,
Christian König
On Mon, Sep 26, 2016 at 10:52 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On So, 2016-09-25 at 15:25 +0800, Baoyou Xie wrote:
>> -int bochs_connector_get_modes(struct drm_connector *connector)
>> +static int bochs_connector_get_modes(struct drm_connector *connector)
>
> Added to drm-qemu queue.
I've thrown this one already into drm-misc, and it's wrapped up in my
latest pull to Dave already.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bochs: mark bochs_connector_get_modes() static
2016-09-26 9:29 ` Daniel Vetter
@ 2016-09-26 10:20 ` Gerd Hoffmann
0 siblings, 0 replies; 5+ messages in thread
From: Gerd Hoffmann @ 2016-09-26 10:20 UTC (permalink / raw)
To: Daniel Vetter
Cc: Baoyou Xie, Arnd Bergmann, tang.qiang007, Baoyou Xie,
Carlos Palminha, dri-devel, Linux Kernel Mailing List, baoyou.xie,
han.fei, alexander.deucher@amd.com, Thierry Reding,
Christian König
On Mo, 2016-09-26 at 11:29 +0200, Daniel Vetter wrote:
> On Mon, Sep 26, 2016 at 10:52 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > On So, 2016-09-25 at 15:25 +0800, Baoyou Xie wrote:
> >> -int bochs_connector_get_modes(struct drm_connector *connector)
> >> +static int bochs_connector_get_modes(struct drm_connector *connector)
> >
> > Added to drm-qemu queue.
>
> I've thrown this one already into drm-misc, and it's wrapped up in my
> latest pull to Dave already.
> -Daniel
Ah, cool, so I don't need an additional drm-qemu pull req.
thanks,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm/bochs: mark bochs_connector_get_modes() static
@ 2016-09-18 13:44 Baoyou Xie
0 siblings, 0 replies; 5+ messages in thread
From: Baoyou Xie @ 2016-09-18 13:44 UTC (permalink / raw)
To: kraxel, airlied, daniel.vetter, alexander.deucher, ville.syrjala,
treding, CARLOS.PALMINHA, christian.koenig
Cc: dri-devel, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/bochs/bochs_kms.c:181:5: warning: no previous prototype for 'bochs_connector_get_modes' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/bochs/bochs_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c
index 207a2cb..0b4e5d1 100644
--- a/drivers/gpu/drm/bochs/bochs_kms.c
+++ b/drivers/gpu/drm/bochs/bochs_kms.c
@@ -178,7 +178,7 @@ static void bochs_encoder_init(struct drm_device *dev)
}
-int bochs_connector_get_modes(struct drm_connector *connector)
+static int bochs_connector_get_modes(struct drm_connector *connector)
{
int count;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-26 10:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-25 7:25 [PATCH] drm/bochs: mark bochs_connector_get_modes() static Baoyou Xie
2016-09-26 8:52 ` Gerd Hoffmann
2016-09-26 9:29 ` Daniel Vetter
2016-09-26 10:20 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2016-09-18 13:44 Baoyou Xie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).