* [PATCH] CHROMIUM: drm/panel: simple: Add support for AUO t215hvn01 @ 2016-10-10 18:29 Haixia Shi 2016-10-10 18:35 ` [PATCH v2] " Haixia Shi 0 siblings, 1 reply; 8+ messages in thread From: Haixia Shi @ 2016-10-10 18:29 UTC (permalink / raw) To: dri-devel; +Cc: Haixia Shi The AUO t215hvn01 is a 21.5" 1920x1080 panel. Signed-off-by: Haixia Shi <hshi@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/394328 Tested-by: Haixia Shi <hshi@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> --- drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 113db3c..bab1951 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -583,6 +583,33 @@ static const struct panel_desc avic_tm070ddh03 = { }, }; +static const struct drm_display_mode auo_t215hvn01_mode = { + .clock = 148800, + .hdisplay = 1920, + .hsync_start = 1920 + 88, + .hsync_end = 1920 + 88 + 44, + .htotal = 1920 + 88 + 44 + 148, + .vdisplay = 1080, + .vsync_start = 1080 + 4, + .vsync_end = 1080 + 4 + 5, + .vtotal = 1080 + 4 + 5 + 36, + .vrefresh = 60, +}; + +static const struct panel_desc auo_t215hvn01 = { + .modes = &auo_t215hvn01_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 430, + .height = 270, + }, + .delay = { + .disable = 5, + .unprepare = 1000, + } +}; + static const struct drm_display_mode chunghwa_claa101wa01a_mode = { .clock = 72070, .hdisplay = 1366, @@ -1575,6 +1602,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "auo,b133xtn01", .data = &auo_b133xtn01, }, { + .compatible = "auo,t215hvn01.0", + .data = &auo_t215hvn01, + }, { .compatible = "avic,tm070ddh03", .data = &avic_tm070ddh03, }, { -- 2.8.0.rc3.226.g39d4020 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] drm/panel: simple: Add support for AUO t215hvn01 2016-10-10 18:29 [PATCH] CHROMIUM: drm/panel: simple: Add support for AUO t215hvn01 Haixia Shi @ 2016-10-10 18:35 ` Haixia Shi 2016-10-10 18:44 ` Sean Paul ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Haixia Shi @ 2016-10-10 18:35 UTC (permalink / raw) To: dri-devel; +Cc: Haixia Shi The AUO t215hvn01 is a 21.5" 1920x1080 panel. v2: fix alphabetical order Signed-off-by: Haixia Shi <hshi@chromium.org> Tested-by: Haixia Shi <hshi@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> --- drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 113db3c..54dbb98 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -555,6 +555,33 @@ static const struct panel_desc auo_b133htn01 = { }, }; +static const struct drm_display_mode auo_t215hvn01_mode = { + .clock = 148800, + .hdisplay = 1920, + .hsync_start = 1920 + 88, + .hsync_end = 1920 + 88 + 44, + .htotal = 1920 + 88 + 44 + 148, + .vdisplay = 1080, + .vsync_start = 1080 + 4, + .vsync_end = 1080 + 4 + 5, + .vtotal = 1080 + 4 + 5 + 36, + .vrefresh = 60, +}; + +static const struct panel_desc auo_t215hvn01 = { + .modes = &auo_t215hvn01_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 430, + .height = 270, + }, + .delay = { + .disable = 5, + .unprepare = 1000, + } +}; + static const struct drm_display_mode avic_tm070ddh03_mode = { .clock = 51200, .hdisplay = 1024, @@ -1575,6 +1602,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "auo,b133xtn01", .data = &auo_b133xtn01, }, { + .compatible = "auo,t215hvn01.0", + .data = &auo_t215hvn01, + }, { .compatible = "avic,tm070ddh03", .data = &avic_tm070ddh03, }, { -- 2.8.0.rc3.226.g39d4020 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/panel: simple: Add support for AUO t215hvn01 2016-10-10 18:35 ` [PATCH v2] " Haixia Shi @ 2016-10-10 18:44 ` Sean Paul 2016-10-10 21:38 ` Emil Velikov 2016-10-10 23:19 ` [PATCH v3] " Haixia Shi 2 siblings, 0 replies; 8+ messages in thread From: Sean Paul @ 2016-10-10 18:44 UTC (permalink / raw) To: Haixia Shi; +Cc: dri-devel On Mon, Oct 10, 2016 at 2:35 PM, Haixia Shi <hshi@chromium.org> wrote: > The AUO t215hvn01 is a 21.5" 1920x1080 panel. > > v2: fix alphabetical order > > Signed-off-by: Haixia Shi <hshi@chromium.org> > Tested-by: Haixia Shi <hshi@chromium.org> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 113db3c..54dbb98 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -555,6 +555,33 @@ static const struct panel_desc auo_b133htn01 = { > }, > }; > > +static const struct drm_display_mode auo_t215hvn01_mode = { > + .clock = 148800, > + .hdisplay = 1920, > + .hsync_start = 1920 + 88, > + .hsync_end = 1920 + 88 + 44, > + .htotal = 1920 + 88 + 44 + 148, > + .vdisplay = 1080, > + .vsync_start = 1080 + 4, > + .vsync_end = 1080 + 4 + 5, > + .vtotal = 1080 + 4 + 5 + 36, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc auo_t215hvn01 = { > + .modes = &auo_t215hvn01_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 430, > + .height = 270, > + }, > + .delay = { > + .disable = 5, > + .unprepare = 1000, > + } > +}; > + > static const struct drm_display_mode avic_tm070ddh03_mode = { > .clock = 51200, > .hdisplay = 1024, > @@ -1575,6 +1602,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "auo,b133xtn01", > .data = &auo_b133xtn01, > }, { > + .compatible = "auo,t215hvn01.0", > + .data = &auo_t215hvn01, > + }, { > .compatible = "avic,tm070ddh03", > .data = &avic_tm070ddh03, > }, { > -- > 2.8.0.rc3.226.g39d4020 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/panel: simple: Add support for AUO t215hvn01 2016-10-10 18:35 ` [PATCH v2] " Haixia Shi 2016-10-10 18:44 ` Sean Paul @ 2016-10-10 21:38 ` Emil Velikov 2016-10-10 23:19 ` [PATCH v3] " Haixia Shi 2 siblings, 0 replies; 8+ messages in thread From: Emil Velikov @ 2016-10-10 21:38 UTC (permalink / raw) To: Haixia Shi, Thierry Reding; +Cc: ML dri-devel On 10 October 2016 at 19:35, Haixia Shi <hshi@chromium.org> wrote: > The AUO t215hvn01 is a 21.5" 1920x1080 panel. > > v2: fix alphabetical order > Thanks for this and dropping the CHOMIUM/Reviewed-on tags. > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1575,6 +1602,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "auo,b133xtn01", > .data = &auo_b133xtn01, > }, { > + .compatible = "auo,t215hvn01.0", We haven't had any compatible strings which end with .0 (or any other number for that matter) for drm panels. The DT binding documentation should mention why, yet there doesn't seem to be a patch for that ? You want one (be that separate patch or part of this one), regardless if the simple panel driver is used or not. If you want to be extra nice to Thierry/Rob H you can even add a link to the spec/data sheet :-) -Emil _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] drm/panel: simple: Add support for AUO t215hvn01 2016-10-10 18:35 ` [PATCH v2] " Haixia Shi 2016-10-10 18:44 ` Sean Paul 2016-10-10 21:38 ` Emil Velikov @ 2016-10-10 23:19 ` Haixia Shi 2016-10-11 21:59 ` [PATCH v4] " Haixia Shi 2 siblings, 1 reply; 8+ messages in thread From: Haixia Shi @ 2016-10-10 23:19 UTC (permalink / raw) To: dri-devel; +Cc: Emil Velikov, Haixia Shi The AUO t215hvn01 is a 21.5" 1920x1080 panel. Link to spec: http://www.udmgroup.com/ftp/T215HVN01.0.pdf v2: fix alphabetical order v3: remove minor revision suffix ".0" and add link to spec Signed-off-by: Haixia Shi <hshi@chromium.org> Tested-by: Haixia Shi <hshi@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Cc: Emil Velikov <emil.l.velikov@gmail.com> Cc: Thierry Reding <thierry.reding@gmail.com> --- drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 113db3c..256c201 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -555,6 +555,33 @@ static const struct panel_desc auo_b133htn01 = { }, }; +static const struct drm_display_mode auo_t215hvn01_mode = { + .clock = 148800, + .hdisplay = 1920, + .hsync_start = 1920 + 88, + .hsync_end = 1920 + 88 + 44, + .htotal = 1920 + 88 + 44 + 148, + .vdisplay = 1080, + .vsync_start = 1080 + 4, + .vsync_end = 1080 + 4 + 5, + .vtotal = 1080 + 4 + 5 + 36, + .vrefresh = 60, +}; + +static const struct panel_desc auo_t215hvn01 = { + .modes = &auo_t215hvn01_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 430, + .height = 270, + }, + .delay = { + .disable = 5, + .unprepare = 1000, + } +}; + static const struct drm_display_mode avic_tm070ddh03_mode = { .clock = 51200, .hdisplay = 1024, @@ -1575,6 +1602,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "auo,b133xtn01", .data = &auo_b133xtn01, }, { + .compatible = "auo,t215hvn01", + .data = &auo_t215hvn01, + }, { .compatible = "avic,tm070ddh03", .data = &avic_tm070ddh03, }, { -- 2.8.0.rc3.226.g39d4020 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v4] drm/panel: simple: Add support for AUO t215hvn01 2016-10-10 23:19 ` [PATCH v3] " Haixia Shi @ 2016-10-11 21:59 ` Haixia Shi 2016-10-18 13:00 ` Rob Herring 2016-10-19 12:34 ` Thierry Reding 0 siblings, 2 replies; 8+ messages in thread From: Haixia Shi @ 2016-10-11 21:59 UTC (permalink / raw) To: dri-devel Cc: Mark Rutland, devicetree, Emil Velikov, linux-kernel, Rob Herring, Haixia Shi The AUO t215hvn01 is a 21.5" FHD (1920x1080) color TFT LCD panel. This panel is used on the Acer Chromebase 21.5-inch All-in-One (DC221HQ). Link to spec: http://www.udmgroup.com/ftp/T215HVN01.0.pdf v2: fix alphabetical order v3: remove minor revision suffix ".0" and add link to spec v4: add dt-binding documentation Signed-off-by: Haixia Shi <hshi@chromium.org> Tested-by: Haixia Shi <hshi@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Cc: Emil Velikov <emil.l.velikov@gmail.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: David Airlie <airlied@linux.ie> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- .../bindings/display/panel/auo,t215hvn01.txt | 7 +++++ drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/auo,t215hvn01.txt diff --git a/Documentation/devicetree/bindings/display/panel/auo,t215hvn01.txt b/Documentation/devicetree/bindings/display/panel/auo,t215hvn01.txt new file mode 100644 index 0000000..cbd9da3 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/auo,t215hvn01.txt @@ -0,0 +1,7 @@ +AU Optronics Corporation 21.5" FHD (1920x1080) color TFT LCD panel + +Required properties: +- compatible: should be "auo,t215hvn01" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 113db3c..256c201 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -555,6 +555,33 @@ static const struct panel_desc auo_b133htn01 = { }, }; +static const struct drm_display_mode auo_t215hvn01_mode = { + .clock = 148800, + .hdisplay = 1920, + .hsync_start = 1920 + 88, + .hsync_end = 1920 + 88 + 44, + .htotal = 1920 + 88 + 44 + 148, + .vdisplay = 1080, + .vsync_start = 1080 + 4, + .vsync_end = 1080 + 4 + 5, + .vtotal = 1080 + 4 + 5 + 36, + .vrefresh = 60, +}; + +static const struct panel_desc auo_t215hvn01 = { + .modes = &auo_t215hvn01_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 430, + .height = 270, + }, + .delay = { + .disable = 5, + .unprepare = 1000, + } +}; + static const struct drm_display_mode avic_tm070ddh03_mode = { .clock = 51200, .hdisplay = 1024, @@ -1575,6 +1602,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "auo,b133xtn01", .data = &auo_b133xtn01, }, { + .compatible = "auo,t215hvn01", + .data = &auo_t215hvn01, + }, { .compatible = "avic,tm070ddh03", .data = &avic_tm070ddh03, }, { -- 2.8.0.rc3.226.g39d4020 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4] drm/panel: simple: Add support for AUO t215hvn01 2016-10-11 21:59 ` [PATCH v4] " Haixia Shi @ 2016-10-18 13:00 ` Rob Herring 2016-10-19 12:34 ` Thierry Reding 1 sibling, 0 replies; 8+ messages in thread From: Rob Herring @ 2016-10-18 13:00 UTC (permalink / raw) To: Haixia Shi Cc: dri-devel, Emil Velikov, Thierry Reding, David Airlie, Mark Rutland, devicetree, linux-kernel On Tue, Oct 11, 2016 at 02:59:16PM -0700, Haixia Shi wrote: > The AUO t215hvn01 is a 21.5" FHD (1920x1080) color TFT LCD panel. > > This panel is used on the Acer Chromebase 21.5-inch All-in-One (DC221HQ). > > Link to spec: http://www.udmgroup.com/ftp/T215HVN01.0.pdf > > v2: fix alphabetical order > v3: remove minor revision suffix ".0" and add link to spec > v4: add dt-binding documentation > > Signed-off-by: Haixia Shi <hshi@chromium.org> > Tested-by: Haixia Shi <hshi@chromium.org> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > Cc: Emil Velikov <emil.l.velikov@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > .../bindings/display/panel/auo,t215hvn01.txt | 7 +++++ > drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++ > 2 files changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/auo,t215hvn01.txt Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] drm/panel: simple: Add support for AUO t215hvn01 2016-10-11 21:59 ` [PATCH v4] " Haixia Shi 2016-10-18 13:00 ` Rob Herring @ 2016-10-19 12:34 ` Thierry Reding 1 sibling, 0 replies; 8+ messages in thread From: Thierry Reding @ 2016-10-19 12:34 UTC (permalink / raw) To: Haixia Shi Cc: Mark Rutland, devicetree, Emil Velikov, linux-kernel, dri-devel, Rob Herring [-- Attachment #1.1: Type: text/plain, Size: 1167 bytes --] On Tue, Oct 11, 2016 at 02:59:16PM -0700, Haixia Shi wrote: > The AUO t215hvn01 is a 21.5" FHD (1920x1080) color TFT LCD panel. > > This panel is used on the Acer Chromebase 21.5-inch All-in-One (DC221HQ). > > Link to spec: http://www.udmgroup.com/ftp/T215HVN01.0.pdf > > v2: fix alphabetical order > v3: remove minor revision suffix ".0" and add link to spec > v4: add dt-binding documentation > > Signed-off-by: Haixia Shi <hshi@chromium.org> > Tested-by: Haixia Shi <hshi@chromium.org> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > Cc: Emil Velikov <emil.l.velikov@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > .../bindings/display/panel/auo,t215hvn01.txt | 7 +++++ > drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++ > 2 files changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/auo,t215hvn01.txt Applied, thanks. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-19 12:34 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-10-10 18:29 [PATCH] CHROMIUM: drm/panel: simple: Add support for AUO t215hvn01 Haixia Shi 2016-10-10 18:35 ` [PATCH v2] " Haixia Shi 2016-10-10 18:44 ` Sean Paul 2016-10-10 21:38 ` Emil Velikov 2016-10-10 23:19 ` [PATCH v3] " Haixia Shi 2016-10-11 21:59 ` [PATCH v4] " Haixia Shi 2016-10-18 13:00 ` Rob Herring 2016-10-19 12:34 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).